Update Dockerfile #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roll Chrome Lacros Arm64 PGO profile from chrome-chromeos-arm64-generic-main-1710417491-55da0987d18b3df7478ede18272316324786fab3-da33c9a2e93faf82ae5487542e95582617bd8615.profdata to chrome-chromeos-arm64-generic-main-1710460899-82b098e053a350c11abeffb16c2b2818f5bb5226-fd6db3292b617fe5624038c4317dea79de47f506.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-lacros-arm64-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: I5f95dce8d267e2ee1813cad0c5d25dd00e21663f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5373648 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1273201}
This CL adds Field Trial Config for ArcIgnoreHoverEventAnr finch experiment. Bug: b:328011215 Change-Id: I02d9d40f935061b493f66486fc9f4908d46b4740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5352934 Auto-Submit: Lingyu Feng <lingyufeng@chromium.org> Reviewed-by: Daichi Hirono <hirono@chromium.org> Commit-Queue: Lingyu Feng <lingyufeng@chromium.org> Cr-Commit-Position: refs/heads/main@{#1273202}
https://skia.googlesource.com/skia.git/+log/9baf6165868e..54ecc23acf31 2024-03-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 14272f958e34 to c73858de2cb7 (6 revisions) 2024-03-14 kjlubick@google.com Remove flutter_defines 2024-03-14 bungeman@google.com Remove SkTypeface::onGetAdvancedMetrics base implementation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: fmalita@google.com Change-Id: I9611e4bcbe629204e4c186267c224ca9d1b3fcc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5373526 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1273203}
Add RTL and 3rd button (remind me later) support to default browser promo view provider. Additionally use that view provider for displaying default browser video promo. Bug: b/298046221 Change-Id: Ia1097d5642cc6494f59e0b7332c54ed994bbe993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5370511 Commit-Queue: Gayane Petrosyan <gayane@google.com> Reviewed-by: Cheick Cisse <cheickcisse@google.com> Reviewed-by: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/main@{#1273204}
1% stable data looks good; per best practices, will request ramp to 100% once this CL reaches a release build. Bug: 40872301 Change-Id: I81bd24993fc8b84af4234ac87a974079379d3a4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5372832 Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/main@{#1273205}
Roll Chrome Mac PGO profile from chrome-mac-main-1710439054-2d3960aea326196a1ef58080c148c6539da38510-80e84fc7bd0e4206b7fc44c9b254da91eeca6c73.profdata to chrome-mac-main-1710460785-6afc19f68882a9ec68c52dae4e408756bbda18a5-74eb4072e43151a657d48a8132a9b52f270e40f1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2a4cd4ab65e2776470cbf78b64cc42abed8dda6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5373471 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1273206}
* This is an automated release commit. * Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true Change-Id: I256e4e0b0aa50a05d35708ab49743d455967f443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5373784 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1273207}
https://chromium.googlesource.com/external/github.com/gpuweb/cts.git/+log/58d25c607b1f..83eda3184821 2024-03-14 github@greggman.com Cleanup texture builtin WGSL validation tests 2024-03-14 dneto@google.com wgsl: validate bad arg counts, arg types, must_use for sin, cos (#3496) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webgpu-cts-chromium-autoroll Please CC bclayton@google.com,webgpu-developers@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-android-arm-deps-rel;luci.chromium.try:dawn-android-arm64-deps-rel;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-mac-arm64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: bclayton@google.com Change-Id: I61f90934056daa5207dd12033c54e0919cb01217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5373396 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1273208}
Roll Chrome Lacros Amd64 PGO profile from chrome-chromeos-amd64-generic-main-1710417491-750c98284e92e4642579634089c36037c9eefc76-da33c9a2e93faf82ae5487542e95582617bd8615.profdata to chrome-chromeos-amd64-generic-main-1710460899-74093f24a2db178de621fb6741b7b9639704934d-fd6db3292b617fe5624038c4317dea79de47f506.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-lacros-amd64-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: I932d1bd7ca348d418c15164448ebad13ca40b6f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5373213 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1273209}
Demo: http://b/327663905#comment2 Fixed: b/327663905 Test: Manual Change-Id: I281632b1edb9af07e0bd7f87e2308eb0f47b2024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5373351 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: Xiaodan Zhu <zxdan@chromium.org> Commit-Queue: Michele Fan <michelefan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1273210}
https://chromium.googlesource.com/angle/angle.git/+log/c3fdc8118978..b5d92511b489 2024-03-14 romanl@google.com Trace tests: log z_stream on decompress failure If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: abdolrashidi@google.com Change-Id: I9d5a588e6f2568f111c69d01e7ac04418c19812b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5373528 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1273211}
Bug: none Change-Id: I63854e8a062be05da83d38093aa1b9622cadbee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5367138 Reviewed-by: Darren Shen <shend@chromium.org> Reviewed-by: Michael Cui <mlcui@google.com> Commit-Queue: Michelle Chen <michellegc@google.com> Cr-Commit-Position: refs/heads/main@{#1273212}
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1710460785-d310ad862a8636cd59ca70bfdb77419b5957393e-74eb4072e43151a657d48a8132a9b52f270e40f1.profdata to chrome-mac-arm-main-1710467850-f07da7e969c358a4eab0f98bdcd343c125605215-63971ca90c81cd1f22cd354a6ed6608781b90d41.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-arm-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2733e131194036c3364057c8ae35696259d39774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5373904 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1273213}
Enable the 'writingsuggestions' feature attribute by default. Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/NhWn64yxB5Q Bug: 41486518 Change-Id: I80973773eed85f3c1b7f903b7a541c839da971b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5370351 Reviewed-by: Sanket Joshi <sajos@microsoft.com> Reviewed-by: Dan Clark <daniec@microsoft.com> Commit-Queue: Stephanie Zhang <stephanie.zhang@microsoft.com> Reviewed-by: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#1273214}
Using wpt-import in Chromium f90635a. With Chromium commits locally applied on WPT: 42290b2 "wpt: Fix test_driver's minimize/restore functions." 07649ab "Revert "Add HandleInvokeInternal on HTMLDialogElement"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mstensho@chromium.org: external/wpt/css/css-break nzolghadr@chromium.org, mustaq@chromium.org: external/wpt/pointerevents NOAUTOREVERT=true R=rubber-stamper@appspot.gserviceaccount.com No-Export: true Validate-Test-Flakiness: skip Cq-Include-Trybots: luci.chromium.try:linux-blink-rel Change-Id: Ia627ff8094e62f8dabee71bc569a9e381b0ce3c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5373583 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1273215}
This CL shows toast when entering the tablet mode with at least one gaming app launched. Bug: b/316036118 Test: ash_unittests --gtest_filter="*GameDashboardContext*" Test: manual test Change-Id: Ie93ab3099dd8f7bf7b92c135a9da7cc0b1d57cd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5371917 Reviewed-by: Michele Fan <michelefan@chromium.org> Commit-Queue: Cici Ruan <cuicuiruan@google.com> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: Jiaming Cheng <jiamingc@chromium.org> Cr-Commit-Position: refs/heads/main@{#1273216}
Replaces most uses of RETURN_IF_ERROR with this macro, which improves readability. Specifically, it allows for replacing many uses of "auto" (previously used to hide overly-verbose expected<T, String> types) with the type of the assigned variable after unwrapping the expected<T, String>. See https://google.github.io/styleguide/cppguide.html#Type_deduction This CL contains no functional changes Bug: 324541572 Change-Id: I33d67d37f493193c578a13a2414b1e4e0cfa6716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5371913 Commit-Queue: Austin Sullivan <asully@chromium.org> Auto-Submit: Austin Sullivan <asully@chromium.org> Reviewed-by: ningxin hu <ningxin.hu@intel.com> Cr-Commit-Position: refs/heads/main@{#1273217}
This is will be used as a replacement for |OneShotTimer|, to allow these call sites to be hooked up to PreFreezeBackgroundMemoryTrimmer. Bug: 1513796 Change-Id: I526307a888c2b8c1d2f65f75aaec926de54cd648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5281576 Reviewed-by: Benoit Lize <lizeb@chromium.org> Commit-Queue: Thiabaud Engelbrecht <thiabaud@google.com> Cr-Commit-Position: refs/heads/main@{#1273218}
When Prerender2 is enabled on WebView, the embedder will need to be able to distinguish prerender navigation vs other navigation. To enable that without a WebView API change, we pass `Sec-Purpose` header to `WebResourceRequest` that `shouldOverrideURLLoading` takes as its `request` argument. [1] [1] https://developer.android.com/reference/android/webkit/WebViewClient#shouldOverrideUrlLoading(android.webkit.WebView,%20android.webkit.WebResourceRequest) Bug: 41490450 Change-Id: Ia181730f01d40ed699fb3441e3dba59ce0414770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5348108 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/main@{#1273219}
The dismiss button was wired to use post redesign event handler. Now it conditionally uses the pre redesign modules event handler. Bug: 329724353 Change-Id: I283fa0e244415e1fcc225d69dac9ca4f8b0ec277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5373483 Commit-Queue: Roman Arora <romanarora@chromium.org> Reviewed-by: Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/main@{#1273220}
…ons) Manual roll requested by abdolrashidi@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/56b277ab9762..91aab7b7e25f Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/2518af09c8..ee2f5d09ea * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/05cc486580..8b246ff75c * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c3a9ffd74f..f869d391a5 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/31aa7f634b..577baa0503 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/71a1694c80..61a9c50248 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/069bd14c05..70bf72330a * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/1b8b60bf7f..a4140c5fd4 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/2b09a7fe46..38311dd809 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll Please CC abdolrashidi@google.com,angle-team@google.com,bclayton@google.com,radial-bots+chrome-roll@google.com,radial-bots@google.com,webgpu-developers@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:win-asan;luci.chromium.try:linux_chromium_cfi_rel_ng Bug: None Tbr: abdolrashidi@google.com,bclayton@google.com,radial-bots+chrome-roll@google.com Change-Id: Ida9c1b64ce33573e6e51a4cca8c89f31a2ece80d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5373377 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1273221}
Bug: 40506050 Change-Id: I48d342b527b6e0185f2e64b2601582770587551a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5373743 Commit-Queue: Giovanni Ortuno Urquidi <ortuno@chromium.org> Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> Auto-Submit: Giovanni Ortuno Urquidi <ortuno@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/main@{#1273222}
Roll Chrome Win32 PGO profile from chrome-win32-main-1710449995-af7bab452e23bded9ea6b4c378d73504ed0a7035-735f7103028c35cb676425108fbd9bd5856b9a0e.profdata to chrome-win32-main-1710460785-4f4a9adfdaa3672abecaa7718838611678da7354-74eb4072e43151a657d48a8132a9b52f270e40f1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ibdb05ba0ccd62bf5812e97a016d5fd2b843607f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5373569 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1273223}
This change allows the routing of video visibility changes notifications, reported by |HTMLVideoElement::ReportVisibility|, through MediaSession. |MediaSessionImpl| iterates through all |normal_players_|, if any of them has a sufficiently visible video, MediaSession will set |meets_visibility_threshold| to true, and false otherwise. Bug: 327267675 Change-Id: I69f3340e299136791196956bcdb1f8692d5c311b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5257077 Commit-Queue: Benjamin Keen <bkeen@google.com> Reviewed-by: Joe Mason <joenotcharles@google.com> Reviewed-by: Tommy Steimel <steimel@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1273224}
MakeFixedFlatSet is only for building compile time maps. As such, there are restrictions on when it can be used: in particular, the set itself must be constructed with a constant expression, which means any variables used in the initializer must also be constexpr variables or be constant-initialized variables. A forward-declared extern variable is neither of these. Rather than trying to make the initializer a constant expression, just use base::flat_map: since this is test-only code, there is no implication on production code anyway. Bug: 41486252 Change-Id: Ic8555b23e95b28bafdb036a0eb5fcccb2634aebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5372938 Auto-Submit: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/main@{#1273225}
Roll Chrome Win64 PGO profile from chrome-win64-main-1710449995-7ecf8b56802fc63da86613990a798e8e9477c212-735f7103028c35cb676425108fbd9bd5856b9a0e.profdata to chrome-win64-main-1710460785-15fe65a7685afb8a0ad524fce6d98c65bef44353-74eb4072e43151a657d48a8132a9b52f270e40f1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4cf8d30725a672dc297929ac28cef793cb8d335f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5373645 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1273226}
Update Chromium's handling of relative URLs by allowing them to have
empty hosts (like "///path") when used with non-special base URLs.
Before:
> const url = new URL("///path", "git://host/a") ;
=> throws an Invalid URL error.
After:
> const url = new URL("///path", "git://host/a") ;
=> `url' is valid. url.href is "git:///path".
This change basically implements "host state" in URL Standard:
https://url.spec.whatwg.org/#host-state
> 2.1. If url is special and buffer is the empty string, host-missing
> validation error, return failure.
Prior CLs already implemented this, but was not implemented correctly in resolving relative URLs for non-special base URLs.
While the WPT URL tests have a good coverage for these scenarios, I also
added unit tests for additional assurance.
Bug: 40063064
Change-Id: I46786955d5db27d29864e80a259ce4076500cb33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5364453
Commit-Queue: Hayato Ito <hayato@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1273227}
In https://crrev.com/c/5362199, GetString and GetURLAndTitle were updated to use std::optional as were all callers. In the original code in menu_view_drag_and_drop_test.cc, two calls to GetString didn't check for the boolean return value, but fell back on default-constructed strings, which can safely be compared to a constant. The new code didn't check the success, but had no fallback, so comparison to a constant would crash. That's a regression in behavior, so add a default value to the calls. Bug: 328710562 Change-Id: I3f17376c4dd50b422e74964d872fe5e2a7b7c20d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5372831 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/main@{#1273228}
This CL adds WPT tests for 1) `input(name, descriptor)` interface, 2) `constant(descriptor, bufferView)` interface, and removes these unit tests 1) `MLGraphBuilderTest.InputTest`, 2) `MLGraphBuilderTest.ConstantTest`. Bug: 327337525, 327337526, 328026885 Change-Id: I95cba29fc189854650ba7ad3bdece4c2d1e26390 Cq-Include-Trybots: luci.chromium.try:win11-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5365030 Commit-Queue: Feng Dai <feng.dai@intel.com> Reviewed-by: Austin Sullivan <asully@chromium.org> Reviewed-by: ningxin hu <ningxin.hu@intel.com> Auto-Submit: Feng Dai <feng.dai@intel.com> Cr-Commit-Position: refs/heads/main@{#1273229}
This CL allows Lacros to use a cros_api call to read the flag values from Ash. Bug: b:329340194 Change-Id: I91f1860d46ee1bae0403c1c1c82a86c318650e37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5366729 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Curtis McMullan <curtismcmullan@chromium.org> Auto-Submit: Chuong Ho <hdchuong@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/main@{#1273230}
Clean up AutofillTouchToFillForCreditCardsAndroid finch flag. Fixed: 40935171 Change-Id: I2e3ebb101426bf8a527c19664ec905aed94f23e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5367087 Commit-Queue: Vishwas Uppoor <vishwasuppoor@google.com> Reviewed-by: Ivana Žužić <izuzic@google.com> Cr-Commit-Position: refs/heads/main@{#1273437}
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1710482292-9e12507b625ef958473689d1e65005199af70d6c-a8edc7ca6f74254d2dba0d96f0f54dbf63505aed.profdata to chrome-android64-main-1710511103-22c3225c5987a578e73c3bdc12ec07e54c7d9c7a-cf94869f98d7707b05d5cd4cee67ae5cdcf3b14c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-android-arm64-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: I2080b9699c4baab36b4c9f4e7262765ab855f4a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5371533 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1273438}
There were no changes done on the old observer even if the block of code looks new here. This is a kill switch to use the old mutations observer if something bad happens with the new version. Logic in sendFormMutationMessagesAfterDelay() can remain as is as the new version should be safe. Bug: 325415935 Change-Id: I99fb5f31268d6622e9adca93b1494b21c75c8dd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5372288 Commit-Queue: Vincent Boisselle <vincb@google.com> Reviewed-by: Ernesto Izquierdo Clua <eic@google.com> Cr-Commit-Position: refs/heads/main@{#1273439}
testDownloadDisplayedPDF is intermittently failing on some bots; mariking it FLAKY. Bug: 329834941 Change-Id: Ia165d4a001d88ff99def60010844105bba53e1fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5372277 Reviewed-by: Vincent Boisselle <vincb@google.com> Auto-Submit: Mark Cogan <marq@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/main@{#1273440}
Roll Chrome Mac PGO profile from chrome-mac-main-1710482292-4c4f49a379e928fa997a17d4ee182282af7945a5-a8edc7ca6f74254d2dba0d96f0f54dbf63505aed.profdata to chrome-mac-main-1710503852-8e08f265d5600ff81ecafb7de6790c1c65056ed9-35a62f3d71173a2187665667a36fbe9e0e36db81.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I5a3e0bb5530498f283c0b39e783b0ac71ec8b708 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5374169 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1273441}
isarkis
force-pushed
the
dev/m114_ci
branch
9 times, most recently
from
160c5cd to
e95c0df
Compare
isarkis
force-pushed
the
isarkis-patch-1
branch
6 times, most recently
from
f41feff to
d5fa27e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.