Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RollingText): add RollingTextGroup #12572

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

nemo-shen
Copy link
Contributor

@nemo-shen nemo-shen commented Jan 16, 2024

issue: #12477

Consider rolling-text-group is a new component, we should upgrade the minor version v4.8.x -> v4.9.0.

rolling-text-group's main goal is to control multiple rolling-text in order to support more scenes for dev. It doest change old using of rolling-text.

Demo

<RollingTextGroup>
  <VanRollingText :target-num="6" />
  <VanRollingText :target-num="6" />
  <span style="display: inline;">.</span>
  <VanRollingText :target-num="6" />
  <VanRollingText :target-num="6" />
</RollingTextGroup>

Main Jobs

  • add rolling-text-group component
  • add rolling-text-group test cases
  • update README of rolling-text, add rolling-text-group using demo

@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (41bbe5b) 89.80% compared to head (d4c2fc7) 89.93%.

Files Patch % Lines
...s/vant/src/rolling-text-group/RollingTextGroup.tsx 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12572      +/-   ##
==========================================
+ Coverage   89.80%   89.93%   +0.12%     
==========================================
  Files         257      259       +2     
  Lines        6830     6864      +34     
  Branches     1657     1663       +6     
==========================================
+ Hits         6134     6173      +39     
+ Misses        373      368       -5     
  Partials      323      323              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nemo-shen nemo-shen marked this pull request as ready for review January 27, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants