-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: SSR hydration error caused by useId #12719
Open
tolking
wants to merge
4
commits into
youzan:main
Choose a base branch
from
tolking:fix/srr-id
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,25 @@ | ||
import { getCurrentInstance } from 'vue'; | ||
import { getCurrentInstance, inject } from 'vue'; | ||
|
||
let current = 0; | ||
const initial = { current: 0 }; | ||
const ID_INJECTION_KEY = 'van-id-injection'; | ||
|
||
export function useId() { | ||
const vm = getCurrentInstance(); | ||
const idInjection = getCurrentInstance() | ||
? inject(ID_INJECTION_KEY, initial) | ||
: initial; | ||
const { name = 'unknown' } = vm?.type || {}; | ||
|
||
// keep test snapshot stable | ||
if (process.env.NODE_ENV === 'test') { | ||
return name; | ||
} | ||
|
||
return `${name}-${++current}`; | ||
if (typeof window === 'undefined' && !inject(ID_INJECTION_KEY)) { | ||
console.warn( | ||
'[vant useId] Looks like you are using server rendering, we suggest injecting an initial value for the ID. eg: app.provide("van-id-injection", { current: 0 })', | ||
); | ||
} | ||
|
||
return `${name}-${++idInjection.current}`; | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
最好是不需要让用户注入内容,因为这样有点复杂了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vue 3.5 会提供一个 hook 来解决这个问题,参考 vuejs/rfcs#557
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
那先等等官方的实现吧。
目前我能够想到避免服务端缓存的最优的方案就是这个。像指令方案改动比较大,或者Nuxt的useId方案不适用于普通的组件库。