-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(imagePreview): Added image preview ability to rotate images #13205
Open
lzxiaoqi
wants to merge
8
commits into
youzan:main
Choose a base branch
from
lzxiaoqi:feat_image_preview
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+188
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13205 +/- ##
==========================================
+ Coverage 89.64% 89.68% +0.04%
==========================================
Files 257 257
Lines 7008 7045 +37
Branches 1733 1740 +7
==========================================
+ Hits 6282 6318 +36
+ Misses 382 381 -1
- Partials 344 346 +2 ☔ View full report in Codecov by Sentry. |
感谢你的 PR!这个功能的实现可能比表面看起来更复杂,需要注意以下几点:
|
@inottn 您好 按照优化建议调整了下。看是否可行 |
抱歉回复晚了。我查看了许多相关的应用后,觉得我们可以将旋转行为限定为 90 度,不支持其他角度。暂时没有想到用户需要非 90 度旋转的场景,这样的设计也能让代码更简洁。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please read the contributing guide.
在提交 pull request 之前,请阅读 贡献指南。
#13153
上面issue中提到的ImagePreview组件增加图片的旋转功能