Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Popup): add destroy-on-close prop #13223

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

inottn
Copy link
Collaborator

@inottn inottn commented Nov 19, 2024

close #13199 close #12796

The combination of the Picker and Popup components is very common. However, a long-standing issue has been that after scrolling to change the selected option in the Picker and then closing the Popup, reopening it causes the Picker to remain at the last scrolled position instead of resetting to the previously selected value. This behavior can be reproduced in the demo examples in the documentation and has caused confusion for many users.

This PR introduces a new destroy-on-close prop and improves the related documentation to address this issue.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.67%. Comparing base (10b72e8) to head (aff1ac5).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13223      +/-   ##
==========================================
+ Coverage   89.59%   89.67%   +0.07%     
==========================================
  Files         257      257              
  Lines        7006     7011       +5     
  Branches     1733     1735       +2     
==========================================
+ Hits         6277     6287      +10     
+ Misses        386      380       -6     
- Partials      343      344       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants