This repository has been archived by the owner on Apr 14, 2024. It is now read-only.
Transform the bin into a lib #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cecton
reviewed
Nov 9, 2021
cecton
reviewed
Nov 9, 2021
cecton
reviewed
Nov 11, 2021
cecton
approved these changes
Nov 11, 2021
cecton
reviewed
Nov 11, 2021
cecton
reviewed
Nov 12, 2021
src/lib.rs
Outdated
Comment on lines
130
to
132
| let mut exit_code: u32 = 0; | ||
|
|
||
| unsafe { |
There was a problem hiding this comment.
Suggested change
| let mut exit_code: u32 = 0; | |
| unsafe { | |
| unsafe { | |
| let mut exit_code: u32 = 0; |
cecton
reviewed
Nov 13, 2021
| inherit_handles: bool, | ||
| current_directory: Option<&Path>, | ||
| ) -> Result<Self> { | ||
| let mut startup_info = STARTUPINFOW::default(); |
There was a problem hiding this comment.
I would start unsafe here in the beginning as the entire logic is one block here
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.