introduce OwnerType #2
Conversation
wxiaoguang
force-pushed
the
improve-runer-type-display
branch
from
1da1a5b to
20b6817
Compare
| concept_system_global = Global | ||
| concept_person_individual = Individual | ||
| concept_code_repository = Repository | ||
| concept_user_organization = Organization |
There was a problem hiding this comment.
individual and organization are both user types. So maybe concept_user_individual is better?
There was a problem hiding this comment.
Sure, feel free to improve~~
There was a problem hiding this comment.
Thank you for your kindness.
I will make the change later.
| @@ -0,0 +1,26 @@ | |||
| package types | |||
There was a problem hiding this comment.
About the file path and the package name.
We have many XxxType in different files now, if we add OwnerType into types package in this PR, does this mean we should move the others into this folder/package in the future?
There was a problem hiding this comment.
I think so, if a type is shared by different packages.
But if a type is specialized for one model, then keep it in its own package.
There was a problem hiding this comment.
I see. How about convert the folder name into shared to make it more clearly to other maintainers?
There was a problem hiding this comment.
maybe sharedtypes? I guess golang doesn't like underline in package name ...
There was a problem hiding this comment.
Ah, I edited my comment.
Maybe models/shared/ownertype.go and package name types is good.
We can add more shared things into this folder if we have.
If there are too many shared types, we can move them into models/shared/types/xxx.go in the future.
Result of `go get -u golang.org/x/net; make tidy`. This is related to the following vulncheck warning: ``` There are 2 vulnerabilities in modules that you require that are neither imported nor called. You may not need to take any action. See https://pkg.go.dev/golang.org/x/vuln/cmd/govulncheck for details. Vulnerability #1: GO-2024-2687 HTTP/2 CONTINUATION flood in net/http More info: https://pkg.go.dev/vuln/GO-2024-2687 Module: golang.org/x/net Found in: golang.org/x/net@v0.22.0 Fixed in: golang.org/x/net@v0.23.0 Vulnerability #2: GO-2022-0470 No access control in github.com/blevesearch/bleve and bleve/v2 More info: https://pkg.go.dev/vuln/GO-2022-0470 Module: github.com/blevesearch/bleve/v2 Found in: github.com/blevesearch/bleve/v2@v2.3.10 Fixed in: N/A ```
No description provided.