Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alert rules to backup #201

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

mt3593
Copy link
Contributor

@mt3593 mt3593 commented Mar 16, 2023

Back up of alert_rules, addresses #197

I am by no means a python developer, so please let me know what i've got wrong

@mt3593
Copy link
Contributor Author

mt3593 commented Mar 16, 2023

I've tested this locally and was able to copy alert rules from one grafana to the other. Not sure what other tests I need to do, let me know

@acjohnson
Copy link
Collaborator

acjohnson commented Mar 17, 2023

@mt3593 Mind adding alert_rules to the list of components in the docopt cli? I know this line is getting long and at some point we'll want to find a better way to format it... but... for now it should at least list all supported components IMHO.
https://github.com/ysde/grafana-backup-tool/blob/master/grafana_backup/cli.py#L28

@mt3593
Copy link
Contributor Author

mt3593 commented Mar 23, 2023

@acjohnson any more to update? or is this good to merge?

@acjohnson acjohnson merged commit b14d649 into ysde:master Mar 23, 2023
@acjohnson
Copy link
Collaborator

Thank you for your contribution @mt3593 !

@mt3593 mt3593 deleted the alert-rules-back-up-and-restore branch March 24, 2023 09:28
@mt3593
Copy link
Contributor Author

mt3593 commented Mar 24, 2023

@acjohnson Thanks for that. When is the next version due for release?

@mt3593
Copy link
Contributor Author

mt3593 commented Apr 3, 2023

@acjohnson Thanks for that. When is the next version due for release?

sorry to pester @acjohnson, keen to get the updated version :)

@acjohnson
Copy link
Collaborator

@ysde The draft 1.2.6 release looks good to me if you want to publish it and get this out the door 😁

@michyliao
Copy link

Hey! Just wanted to mention that this merge should have a break change notice - to be up to date with the latest grafana version. We're still using 8.2.4 and our backup job failed with a 404 on alert-rules.

@acjohnson
Copy link
Collaborator

@michyliao thank you for the heads up in that case it'd be better if we can add a version check for alert-rules support rather than adding a break change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants