Fix 100% opaticy rule with inactive-opacity

[llitz]

@yshui, can you accept this? I have sent this upstream but I wanted to make sure we would keep your branch updated.

When inactive-opacity is enabled, you can override the opacity by using opacity-rule.

By default, all windows have 100 opacity and, if it is still at 100,
inactive-opacity will be applied when the window loses focus. This
patch adds a new bool opacity_disabled to win struct and verify this
variable before deciding if it should be excluded from inactive-opacity

Fix 99% transparency problems on chjj/compton#450 chjj/compton#433
chjj/compton#403 chjj/compton#367 chjj/compton#260 chjj/compton#182
chjj/compton#158

[yshui]

@llitz Feels like to me this does not fix the root of the problem? Why does setting opacity to 100 not make the window completely opaque?

[llitz]

It does fix. By default, every window has 100 opacity already and if it is at 100 and inactive opacity is enabled then the inactive opacity is enabled. The way opacity-rule and inactive-opacity were implemented is kind of a hack as none of then has an actual enabled/disabled flag. This fixes the race condition and detects when you manually set it to 100% which is "keep my window completely visible"

…

On Sat, Aug 11, 2018, 6:42 AM yshui ***@***.***> wrote: @llitz <https://github.com/llitz> Feels like to me this does not fix the root of the problem? Why does setting opacity to 100 not make the window completely opaque? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AVbEO19gWSSfLZnYi6SYeFMEeEfNPiW-ks5uPtEggaJpZM4V44H0> .

[yshui]

@llitz I opt to solve this problem in a (IMO) better way. If you can give 30c14c06d2eef008a7eeb3c0e23d8a08c8ba37e1 (the opacity branch) a try and report back, that will be much appreciated.

[llitz]

I will take a look at this, but from what I saw in the code the default active opacity is always 1 (in double long) already. If this works it should be fine. There's an edge case the code takes care which is when the WM is poorly written so it will keep track of some transparency information from the client side, not sure if this would disrupt that.

…

On Sat, Aug 11, 2018, 12:51 PM yshui ***@***.***> wrote: @llitz <https://github.com/llitz> I opt to solve this problem in a (IMO) better way. If you can give 30c14c0 <30c14c0> a try and report back, that will be much appreciated. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AVbEO-KsXKZ_tNxf8w1c7TQYSUlyi7xvks5uPyfFgaJpZM4V44H0> .

[llitz]

@yshui Your opacity branch works perfectly and looks a very interesting approach, I was worried about changing too much of the code without knowing it and breaking more things than fixing it. You fixed the whole implementation (=

I will keep running it and let you know if I face any bug that could be related to it.

[yshui]

@llitz Yes, please. If you can keep testing, that will be great. I'm worried about this might break random seemingly unrelated things as well.

[llitz]

While this branch works, I tried to merge/rebase it with your master. Commit 27fc4a2 seems to be causing issues for me:
compton: src/compton.c:6603: init_filters: Assertion `false' failed.

Going to try it without that one. I am on gcc 8.2 by the way.

[yshui]

@llitz which backend are you using? And did you have NO_VSYNC_OPENGL in your build options?

[yshui]

@llitz Should be fixed with the most recent master

[llitz]

@yshui I will test again, we may want to open a different issue to track it as it was related to a different issue. Anyway, I don't think I have anything special on my build options. I should only have NO_DBUS on my build process (been testing different versions on a gentoo build). I should be able to test a new version later today/tomorrow.

[llitz]

Last master commit has fixed it (=. The version I am currently running is the opacity branch with a master rebase, so I should have all patches in this code.

Relevant definitions on my code are:
-DCONFIG_XINERAMA -DCONFIG_LIBCONFIG -DCONFIG_REGEX_PCRE -DCONFIG_REGEX_PCRE_JIT -DCONFIG_VSYNC_DRM -DCONFIG_VSYNC_OPENGL -DCONFIG_VSYNC_OPENGL_GLSL -DCONFIG_VSYNC_OPENGL_FBO -DCONFIG_VSYNC_OPENGL_VBO -DCONFIG_XSYNC -DCONFIG_C2

[yshui]

@llitz Closing this since opacity branch is merged into master