fix various memory leaks #1357
fix various memory leaks #1357
Conversation
…c and transition/script.c
| free(info); | ||
| } | ||
| free(info); | ||
| } |
There was a problem hiding this comment.
this looks wrong, won't this leak info?
There was a problem hiding this comment.
I check again, but in its original position where the fault appeared.
There was a problem hiding this comment.
ok, but can you explain why this leaks? or are you making changes without understanding just to make warnings go away?
| @@ -609,6 +612,7 @@ void *parse_window_shader_prefix(const char *src, const char **end, void *user_d | |||
| char *tmp = (char *)trim_both(untrimed_shader_source, &length); | |||
| tmp[length] = '\0'; | |||
| char *shader_source = NULL; | |||
| free(untrimed_shader_source); | |||
There was a problem hiding this comment.
this is unnecessary. untrimed_shader_source is automatically freed when it's out of scope.
| @@ -581,6 +583,7 @@ void parse_debug_options(struct debug_options *debug_options) { | |||
| parse_debug_option_single(needle, debug_options); | |||
| needle = strtok_r(NULL, ";", &tmp); | |||
| } | |||
| free(debug_copy); | |||
There was a problem hiding this comment.
unnecessary, same as untrimed_shader_source
| free(config_home); | ||
| return ret; | ||
| } | ||
| } | ||
| free(config_home); |
|
hey, thanks for investigating this! if you look at the definition of |
I'm reworking the commit, this time taking into account what you've commented, thanks for the feedback. |
Hi, this changes fix a few memory leaks detected by clang-static-analyzer. The fixes are in backend/egl.c, backend/glx.c, src/config.c and transition/script.c
There are other issues detected, but touching them will break picom, so we'll have to keep checking these new fixes. At the moment, these fixes work perfectly on my machine (FreeBSD) for both amd64 and i386.
As I fix the rest of the bugs detected with clang-static-analyzer, I'll upload the rest of the commits.