fix: nix overlays #1374
Merged
fix: nix overlays #1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks. you seems to have formatted the nix file, making it difficult to review. can you amend the commit to just include the changes you want? |
Lenivaya
force-pushed
the
fix/nix/overlay
branch
from
9c3c52c
to
1df253e
Compare
Done |
yshui
force-pushed
the
fix/nix/overlay
branch
from
1df253e
to
d62fd41
Compare
|
@Lenivaya, it seems that you have contributed under two different e-mails. which one do you prefer to be included in the |
Second |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error info
After some recent changes, flake overlays stopped working, narrowing down the problem this is probably because of doing overlay for git-ignore-nix which is not a package but a flake (so the package can't really receive that git-ignore-nix). Passing git-ignore-nix as a direct argument to the package fixes the overlay usage for me, should work for others too.
Example of error
error: evaluation aborted with the following error message: 'lib.customisation.callPackageWith: Function called without required argument "git-ignore-nix"