Aadil dns issue #44
Merged
Aadil dns issue #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'.' was incorrectly appended to DNSName with only a single label Signed-off-by: Mohammad Aadil Shabier <aadilshabier1@gmail.com>
The variables i and remaining were being incremented before the rdata was parsed. They were also directly accessed from within the match case for SOA. Fixed packet::tests::parse_failing_packet_* to fail on error now. Signed-off-by: Mohammad Aadil Shabier <aadilshabier1@gmail.com>
gabhijit
force-pushed
the
aadil-dns-issue
branch
from
478e450 to
c8dbe89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.