Remove lazy_static #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csking101
force-pushed
the
remove_lazy_static
branch
from
256563a to
3b3f655
Compare
gabhijit
requested changes
Mar 10, 2024
|
I'd rebased already it in the force push, do I need to do it once again to squash into a single commit? |
|
@csking101 : What I generally do is - if there are more than one commits - Just squash into one logical commit, so that the history looks okay. I can do it for you as well. But if you do it, I will just merge it. |
Signed-off-by: csking101 <chinmayasahu101@gmail.com> Removed lazy_static Signed-off-by: csking101 <chinmayasahu101@gmail.com> Some cosmetic changes Signed-off-by: csking101 <chinmayasahu101@gmail.com>
csking101
force-pushed
the
remove_lazy_static
branch
from
3b3f655 to
4e4ac6f
Compare
|
I have tried squashing it now, could you please check sir. |
gabhijit
approved these changes
Mar 11, 2024
|
@csking101 : I have made minor edits to the git commit message and then merged that. This functionality is now available in the main branch. Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#42
Removed
lazy_staticand implementedOnceLock