Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to new sortorder import path #682

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Migrate to new sortorder import path #682

merged 1 commit into from
Sep 14, 2020

Conversation

fvbommel
Copy link
Contributor

Pull Request description

Due to some issues with the server handling the vanity imports, I unfortunately had to move the vbom.ml/util package to github.com/fvbommel/util. Since I was breaking import paths anyway, I decided to also move the much more popular sortorder sub-package to github.com/fvbommel/sortorder instead.

See fvbommel/util#7

Description of the change

I've updated the import path to the new location.

What I did

I've updated the import path where it was used.

How I did it

I've updated the import path where it was used.

How to verify it

The actual code of the imported package hasn't changed, as can be seen in the Blame view.
The only changes to the .go files have been to remove the vanity import and to remove a test dependency.

Description for the changelog

Updated import path of vbom.ml/util/sortorder to github.com/fvbommel/sortorder

Applicable Issues

None.

@codeclimate
Copy link

codeclimate bot commented Sep 13, 2020

Code Climate has analyzed commit 6f404bb and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Member

@loicalbertin loicalbertin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👏

Thank you very much @fvbommel, that's good to see someone that take care of downstream projects when renaming import paths! 👍

@loicalbertin loicalbertin merged commit fc0bd72 into ystia:develop Sep 14, 2020
@fvbommel
Copy link
Contributor Author

Yes, I felt kind of bad about that rename but I think it's the best solution in the long term. Helping out importers is my way of helping ease the pain 😉.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants