-
Notifications
You must be signed in to change notification settings - Fork 22
Use esbuild instead of rollup #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Not sure who to ping here for Nix, but @Mynacol or @SuperSandro2000: I'm intending to drop It would be nice to know if this combination would still work for you guys. |
|
Seems to work for us: |
Fixes #42
Still work in progress as yt-dlp will have to be adapted for the resulting bundles for testing.
This is slightly problematic as we
deno task bundleto usedeno, nothing else. We could keep it like this and just keep the precedence logic.This also gets rid of some dependencies and moves all of the building logic into Python land, so we don't ever have to invoke javascript for the actual building part.