Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ie/youtube] Fix failing nsig decoding for player b22ef6e7 #10390

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

bashonly
Copy link
Member

@bashonly bashonly commented Jul 8, 2024

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence): co-authored by @seproDev

What is the purpose of your pull request?

  • Fix or improvement to an extractor (Make sure to add/update tests)

@bashonly bashonly added bug Bug that is not site-specific site-bug Issue with a specific website labels Jul 8, 2024
@bashonly bashonly force-pushed the fix/yt-nsig-func branch from b7faee2 to 287c2c8 Compare July 8, 2024 20:51
bashonly added a commit to bashonly/yt-dlp that referenced this pull request Jul 8, 2024
Closes yt-dlp#10391
Authored by: bashonly, seproDev

Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
@bashonly bashonly force-pushed the fix/yt-nsig-func branch from 287c2c8 to cd2ab64 Compare July 8, 2024 20:52
Closes yt-dlp#10391
Authored by: bashonly, seproDev

Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
@bashonly bashonly force-pushed the fix/yt-nsig-func branch from cd2ab64 to 9d7e444 Compare July 8, 2024 21:50
@bashonly bashonly merged commit 297b0a3 into yt-dlp:master Jul 8, 2024
15 checks passed
@bashonly bashonly deleted the fix/yt-nsig-func branch July 8, 2024 22:04
dirkf added a commit to dirkf/youtube-dl that referenced this pull request Jul 10, 2024
* improve extraction of function name (like yt-dlp/yt-dlp#10390)
* always use JSInterp to extract function code (yt-dlp/yt-dlp#10396, thx seproDev, pukkandan)
dirkf added a commit to dirkf/youtube-dl that referenced this pull request Jul 10, 2024
* improve extraction of function name (like yt-dlp/yt-dlp#10390)
* always use JSInterp to extract function code (yt-dlp/yt-dlp#10396, thx seproDev, pukkandan)
dirkf added a commit to dirkf/youtube-dl that referenced this pull request Jul 10, 2024
* improve extraction of function name (like yt-dlp/yt-dlp#10390)
* always use JSInterp to extract function code (yt-dlp/yt-dlp#10396, thx seproDev, pukkandan)
dirkf added a commit to ytdl-org/youtube-dl that referenced this pull request Jul 10, 2024
* improve extraction of function name (like yt-dlp/yt-dlp#10390)
* always use JSInterp to extract function code (yt-dlp/yt-dlp#10396, thx seproDev, pukkandan)
dirkf added a commit to ytdl-org/ytdl-nightly that referenced this pull request Jul 11, 2024
* improve extraction of function name (like yt-dlp/yt-dlp#10390)
* always use JSInterp to extract function code (yt-dlp/yt-dlp#10396, thx seproDev, pukkandan)
github-actions bot added a commit to hellopony/youtube-dl that referenced this pull request Jul 11, 2024
* https://github.com/ytdl-org/youtube-dl:
  [YouTube] Fix nsig processing for player `b22ef6e7` * improve extraction of function name (like yt-dlp/yt-dlp#10390) * always use JSInterp to extract function code (yt-dlp/yt-dlp#10396, thx seproDev, pukkandan)
  [jsinterp] Support functionality for player `b22ef6e7` * support `prototype` for call() and apply() (yt-dlp/yt-dlp#10392, thx Grub4k) * map JS `Array` to `list`
  [jsinterp] Further improve expression parsing (fix fd8242e) Passes tests from yt-dlp
  [jsinterp] Re-align JSInterp and tests (esp.) with yt-dlp Thx: various yt-dlp authors
  [core] Address gaps in allowed extensions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug that is not site-specific site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants