Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] merge yt-4 with master #2172

Closed
wants to merge 1,549 commits into from
Closed

Conversation

ngoldbaum
Copy link
Member

This tracks merging with yt-4 branch with master. This is not going to be useful for review but I'm opening now so I can work on getting the tests passing.

We will have a discussion on the mailing list about merging this.

@ngoldbaum
Copy link
Member Author

The py2 build failures can be ignored because master won't support python2 anymore once this PR is merged.

@matthewturk matthewturk added triage Triage needed demeshening Removing the global mesh for particles yt core Core components and algorithms in yt and removed triage Triage needed labels Mar 6, 2019
@matthewturk
Copy link
Member

I've updated the merge branch with most recent changes on both master and yt-4.0. The vector operations were a bit tricky to merge, but I think I got it.

@ngoldbaum I'm not sure if we can edit the pull request, but if the messages get too annoying we can switch it to being from my fork/branch.

@ngoldbaum
Copy link
Member Author

No worries, let me know if you need a hand with anything.

@matthewturk
Copy link
Member

Sneaky proj and quad_proj change now fixed for the ytdata tests!

@matthewturk
Copy link
Member

@qobilidop Not sure if you're the right person to ask, but you might have an idea. The answer tests for tipsy are failing, and I'm not sure why they were ever passing before, but you might know why!

Right now the Tipsy tests run:

for test in sph_answer(ds, 'galaxy.00300', 315372, tg_fields):
    ...
    yield test

We're testing these fields:

tg_fields = OrderedDict(                                                                                                                      
    [                                                                                                                                         
        (('gas', 'density'), None),                                                                                                           
        (('gas', 'temperature'), None),                                                                                                       
        (('gas', 'temperature'), ('gas', 'density')),                                                                                         
        (('gas', 'velocity_magnitude'), None),                                                                                                
        (('gas', 'Fe_fraction'), None),                                                                                                       
        (('Stars', 'Metals'), None),                                                                                                          
    ]                                                                                                                                         
)  

The thing is, it seems to me that this should not actually ever pass -- the only fields that are of that particular size are the ones that are the all particle union.

So I guess I'm not sure why this ever worked? But more to the point, I wonder if you have any insight into why the unions and whatnot might give different results now.

@matthewturk
Copy link
Member

Never mind, I figured it out! We now have an "nbody" type. I'll address this.

@jzuhone
Copy link
Contributor

jzuhone commented May 15, 2019

@matthewturk keep in mind that PR #2208 needs to be merged before a lot of these tests even work?

@matthewturk
Copy link
Member

@jzuhone well crumbs, now I feel extra silly.

jzuhone and others added 11 commits May 19, 2019 22:55
Improvements to reading / writing FITS images
This halves the runtime of scripts like in yt-project#2146 for MassiveFIRE
snapshots when run on HiPerGator's lustre filesystem.
On such snapshots yt used to redundantly scan the backing HDF5
files 243 times for what Datasets they contain.
Cache the result of _identify_fields to improve dataset initialization speed
@matthewturk
Copy link
Member

So #2208 has been merged, and I am going to poke more at this.

@cphyc cphyc mentioned this pull request Jan 28, 2020
3 tasks
@matthewturk
Copy link
Member

I'm closing and re-issuing from my repository!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
demeshening Removing the global mesh for particles yt core Core components and algorithms in yt
Projects
None yet
Development

Successfully merging this pull request may close these issues.