-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] merge yt-4 with master #2172
Conversation
The py2 build failures can be ignored because master won't support python2 anymore once this PR is merged. |
I've updated the merge branch with most recent changes on both master and yt-4.0. The vector operations were a bit tricky to merge, but I think I got it. @ngoldbaum I'm not sure if we can edit the pull request, but if the messages get too annoying we can switch it to being from my fork/branch. |
No worries, let me know if you need a hand with anything. |
Sneaky |
@qobilidop Not sure if you're the right person to ask, but you might have an idea. The answer tests for tipsy are failing, and I'm not sure why they were ever passing before, but you might know why! Right now the Tipsy tests run:
We're testing these fields:
The thing is, it seems to me that this should not actually ever pass -- the only fields that are of that particular size are the ones that are the So I guess I'm not sure why this ever worked? But more to the point, I wonder if you have any insight into why the unions and whatnot might give different results now. |
Never mind, I figured it out! We now have an "nbody" type. I'll address this. |
@matthewturk keep in mind that PR #2208 needs to be merged before a lot of these tests even work? |
@jzuhone well crumbs, now I feel extra silly. |
Improvements to reading / writing FITS images
This halves the runtime of scripts like in yt-project#2146 for MassiveFIRE snapshots when run on HiPerGator's lustre filesystem. On such snapshots yt used to redundantly scan the backing HDF5 files 243 times for what Datasets they contain.
Cache the result of _identify_fields to improve dataset initialization speed
…we make new images from preexisting ones
Remove copyright notices
[bugfix] Various bug fixes which came up in daily use of yt-4.0
…opies Gadget io fewer calls to reading
So #2208 has been merged, and I am going to poke more at this. |
I'm closing and re-issuing from my repository! |
This tracks merging with yt-4 branch with master. This is not going to be useful for review but I'm opening now so I can work on getting the tests passing.
We will have a discussion on the mailing list about merging this.