add a list_annotations() method #2562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@munkm I renamed this function as you suggested. |
munkm
approved these changes
Apr 27, 2020
There was a problem hiding this comment.
Thanks for updating the method name! This looks great.
Continuing our conversation from the previous PR, I've opened an issue #2564 to propose changing the name of annotate_clear to clear_annotations like you suggested in the previous PR.
brittonsmith
approved these changes
May 1, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The
annotate_clear()method takes an optional index of the annotation to remove, but thereis not high-level method to see the indices of the currently applied annotations. This adds a list_annotations() method to allow us to see what annotations are currently applied.
This reissues #2498.
PR Checklist