Support vertex centred data #2615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cphyc
force-pushed
the
support-vertex-centred-data
branch
from
4d6c62e to
0d0a7f3
Compare
|
@yt-fido test this please |
|
/format |
cphyc
force-pushed
the
support-vertex-centred-data
branch
from
0d0a7f3 to
ca02f97
Compare
|
This one's ready to go! |
This add support for computing e.g. isocontours for RAMSES datasets. This could in principle be extended to any oct-based dataset, but that'd require extra work. |
cphyc
force-pushed
the
support-vertex-centred-data
branch
from
626610a to
04acdf8
Compare
neutrinoceros
approved these changes
Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for vertex centred data. This has the effect of making isocontours possible on octree datasets using the same API as for the rest of yt.
This should be merged after #2425 has been merged. I marked it as draft to prevent people from reviewing it, since many files have been modified in the aforementioned PRs.
This allows for example to export a dataset to sketchfab.
Note that in its current form, the isosurface algorithm does work. However, it is very slow as it performs the marching cube algorithm on each individual oct. It also returns a non-connected set of points (that represent the isosurface), since the output of the marching cube algorithms aren't stitched together. Note that a quick hack would be to merge vertices of the isosurface if they are very close one from another. A better solution however would be to feed sets of connected octs that live at the same level to the marching cube algorithms, but this is well beyond the scope of the current PR.