hotfix: support matplotlib 3.3.0 #2754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
added
bug
api-consistency
|
matplotlib's version is currently pinned to 3.1.3 in our test requirements, maybe it's time to bump it ? |
Xarthisius
approved these changes
Jul 17, 2020
jzuhone
approved these changes
Jul 17, 2020
munkm
approved these changes
Jul 17, 2020
| _png.write_png(buffer, fileobj, dpi) | ||
| try: | ||
| # matplotlib switched from an internal submodule _png to using pillow (PIL) | ||
| # between v3.1.0 and v3.3.0 |
There was a problem hiding this comment.
This is a good solution for the imports. Thanks for adding the message too for our future devs. 🙂
| with open(filename, "wb") as fileobj: | ||
| call_png_write_png(buffer, width, height, fileobj, dpi) | ||
| call_png_write_png(buffer, fileobj, dpi) |
There was a problem hiding this comment.
I wonder why the width and height were passed to the previous function when it seems like it didn't use them? Thanks for cleaning that up.
…by using pillow instead of the old _png module
neutrinoceros
force-pushed
the
hotfix_mpl3.3_support
branch
from
ba74175 to
6a5b6b1
Compare
matthewturk
added a commit
to matthewturk/yt
that referenced
this pull request
Jul 31, 2020
Closed
munkm
pushed a commit
to munkm/yt
that referenced
this pull request
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
fix #2752
I also simplified
call_png_write_pngsince it had two required positional arguments that were actually not used.