Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/2892 #2922

Merged
merged 2 commits into from
Sep 23, 2020
Merged

bugfix/2892 #2922

merged 2 commits into from
Sep 23, 2020

Conversation

cphyc
Copy link
Member

@cphyc cphyc commented Sep 23, 2020

PR Summary

This fixes #2892. The issue is that setup.py install does not call build_ext if ext_modules is empty.
This is fixed by customizing the distribution class and always assume there are some extensions to be built.

I am not quite sure how to test it, but on my local machine pip install . now works from the folder that contains yt, as well as pip install git+file://path/toyt/source/code.

PR Checklist

  • pass black --check yt/
  • pass isort . --check --diff
  • pass flake8 yt/
  • pass flynt yt/ --fail-on-change --dry-run -e yt/extern
  • New features are documented, with docstrings and narrative docs
  • Adds a test for any bugs fixed. Adds tests for new features.

@cphyc cphyc added the bug label Sep 23, 2020
@cphyc
Copy link
Member Author

cphyc commented Sep 23, 2020

It looks like it is working on my local machine. Could anyone on Mac/Windows give it a try and install it using?

pip install git+git://github.com/cphyc/yt.git@bugfix/2892

@neutrinoceros
Copy link
Member

I'm going to try this on my Mac :)

Copy link
Member

@neutrinoceros neutrinoceros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to reproduce the error on my Mac and this indeed fixes it; well done !

setup.py Outdated Show resolved Hide resolved
@neutrinoceros neutrinoceros merged commit bcd736b into yt-project:master Sep 23, 2020
@cphyc cphyc deleted the bugfix/2892 branch September 23, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fresh yt installation not importing
2 participants