Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly raise exceptions that occur during parallel build #2948

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

Xarthisius
Copy link
Member

Motivation

Currently, when one of the Cython extensions fails to compile in a parallel build process, it does not stop the build. In the best case scenario the process will fail during install step with a cryptic:

error: can't copy 'build/lib/yt/geometry/particle_oct_container.cpython-36m-x86_64-linux-gnu.so': doesn't exist or not a regular file

or in the worst case it will silently create a faulty wheel that will install yt, which will fail during import.
This PR properly raises any exception raised in parallel build threads resulting in fatal error stopping the entire install process after build extensions phase.

How to test?

export CC=$(which gcc-5)
export CXX=$(which g++-5)
python3 -m pip wheel .

@Xarthisius Xarthisius added the bug label Oct 20, 2020
@munkm munkm merged commit b42579b into yt-project:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants