Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: AdaptaHOP more flexible support #3254

Merged
merged 8 commits into from
Nov 1, 2021

Conversation

cphyc
Copy link
Member

@cphyc cphyc commented May 10, 2021

PR Summary

PR Checklist

  • New features are documented, with docstrings and narrative docs
  • Adds a test for any bugs fixed. Adds tests for new features.

@cphyc cphyc marked this pull request as draft May 10, 2021 16:24
@cphyc cphyc changed the title adaptahop-support-longint AdaptaHOP more flexible support May 10, 2021
@cphyc cphyc force-pushed the adaptahop-support-longint branch from 930ac0f to c92fcbe Compare July 19, 2021 14:54
@cphyc cphyc marked this pull request as ready for review July 26, 2021 10:52
@cphyc cphyc added code frontends Things related to specific frontends enhancement Making something better refactor improve readability, maintainability, modularity labels Jul 26, 2021
@cphyc
Copy link
Member Author

cphyc commented Jul 26, 2021

The failing tests should pass once yt-project/website#109 is merged and if the dataset is added to jenkins (@Xarthisius?)

@cphyc cphyc force-pushed the adaptahop-support-longint branch from 227149b to a017a23 Compare July 26, 2021 14:07
@cphyc
Copy link
Member Author

cphyc commented Jul 27, 2021

@yt-fido test this please

@matthewturk
Copy link
Member

@brittonsmith would you be able to take a look at this?

@matthewturk matthewturk changed the title AdaptaHOP more flexible support ENH: AdaptaHOP more flexible support Oct 9, 2021
@matthewturk matthewturk enabled auto-merge November 1, 2021 17:51
@matthewturk matthewturk merged commit b7dfe4a into yt-project:main Nov 1, 2021
@matthewturk
Copy link
Member

@brittonsmith I'm officially taking this off your plate, after having reviewed it myself.

@cphyc cphyc deleted the adaptahop-support-longint branch November 2, 2021 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code frontends Things related to specific frontends enhancement Making something better refactor improve readability, maintainability, modularity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants