Change the loop order to avoid executing the same test 3 times #3402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
approved these changes
Jul 1, 2021
|
got a network error in load_sample tests, I relaunched the culprit job. |
matthewturk
approved these changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just to be extra sure that we're doing the right thing, we've been running the same
FieldValuesTest3 times every timesmall_patch_amrwas used. No big deal! It's better to be safe than sorry! However, as I grow older I discover a daredevil in me. So I say: let's live our lives dangerously and run this test only once! How about that?PR Summary
This PR switches the order of loops in
small_patch_amrto allowFieldValuesTestto be run once, since it's independent ofaxisparameter.