Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert empty link to navbar in hope it fixes #3422 #3423

Merged
merged 2 commits into from
Jul 9, 2021

Conversation

Xarthisius
Copy link
Member

PR Summary

Since the behavior mentioned in #3422 always applies to first item in the navbar, I inserted and empty link. However, I'm open to ideas if someone knows how to do it via e.g. css...

@Xarthisius Xarthisius added docs enhancement Making something better labels Jul 8, 2021
@matthewturk
Copy link
Member

I spent a handful of minutes trying to find the correct CSS incantation to correctly negate :not(li) > ol > li:first-child > :first-child, :not(li) > ul > li:first-child > :first-child and could not.

Copy link
Member

@chummels chummels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.

Copy link
Member

@neutrinoceros neutrinoceros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems reasonable, though I'm unsure how to check that it actually works. In any case, I'd suggest keeping a trace of why this one line was inserted, it seems really easy to loose track of.

doc/source/conf.py Outdated Show resolved Hide resolved
@Xarthisius
Copy link
Member Author

this seems reasonable, though I'm unsure how to check that it actually works.

https://tests.yt-project.org/job/yt_docs_new/1604/artifact/doc/build/html/index.html

Co-authored-by: Clément Robert <cr52@protonmail.com>
@neutrinoceros neutrinoceros merged commit 9747a6a into yt-project:main Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs enhancement Making something better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants