Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] Get order of axes right for FITSParticleProjection #3488

Merged
merged 1 commit into from
Aug 30, 2021
Merged

[bugfix] Get order of axes right for FITSParticleProjection #3488

merged 1 commit into from
Aug 30, 2021

Conversation

jzuhone
Copy link
Contributor

@jzuhone jzuhone commented Aug 29, 2021

PR Summary

This is a follow on to PR #3375. It turns out that the order of the axis_wcs list here, which is used to figure out what the axes should be for a given projection direction, had the 0/x and 2/z axes in the wrong order to pass to the ParticleImageBuffer.

PR Checklist

  • New features are documented, with docstrings and narrative docs
  • Adds a test for any bugs fixed. Adds tests for new features.

@jzuhone jzuhone added the bug label Aug 29, 2021
matthewturk
matthewturk approved these changes Aug 29, 2021
View reviewed changes
Copy link
Member

@matthewturk matthewturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@neutrinoceros
Copy link
Member

neutrinoceros commented Aug 29, 2021 •
edited
Loading

I think the failures on Jenkins have nothing to do with that PR and were also seen in daily runs recently.

@neutrinoceros neutrinoceros mentioned this pull request Aug 30, 2021
Closed
@neutrinoceros
Copy link
Member

I think it should be ok to merge this as is. @jzuhone you have my benediction to merge this yourself if you're fine with ignoring the unrelated Jenkins errors (reported as #3491)

@jzuhone jzuhone merged commit 70197e0 into yt-project:main Aug 30, 2021
@neutrinoceros neutrinoceros mentioned this pull request Oct 12, 2021
Closed
42 tasks
@matthewturk
Copy link
Member

@meeseeksdev backport to yt-4.0.x

meeseeksmachine pushed a commit to meeseeksmachine/yt that referenced this pull request Oct 15, 2021
@jzuhone @meeseeksmachine
Backport PR yt-project#3488: [bugfix] Get order of axes right for FIT…
f3c71c0 
…SParticleProjection
@meeseeksmachine meeseeksmachine mentioned this pull request Oct 15, 2021
Merged
neutrinoceros added a commit that referenced this pull request Oct 16, 2021
@neutrinoceros
Merge pull request #3585 from meeseeksmachine/auto-backport-of-pr-348…
0908e9a 
…8-on-yt-4.0.x

Backport PR #3488 on branch yt-4.0.x ([bugfix] Get order of axes right for FITSParticleProjection)
@jzuhone jzuhone deleted the fix_fits_y_axis branch October 24, 2021 04:46
@neutrinoceros neutrinoceros added this to the 4.0.2 milestone May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewturk matthewturk matthewturk approved these changes

@neutrinoceros neutrinoceros neutrinoceros approved these changes

Assignees
No one assigned
Labels
bug viz: 2D
Projects
None yet
Milestone
4.0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@jzuhone @neutrinoceros @matthewturk