Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT: hotfix CI #3504

Closed
wants to merge 5 commits into from
Closed

MNT: hotfix CI #3504

wants to merge 5 commits into from

Conversation

neutrinoceros
Copy link
Member

PR Summary

Right now our Github Actions-based CI is completely broken as it fails the install stage.
I'm suspecting the most recent updates in setuptools to be responsible. Specifically pypa/setuptools#2775

This is meant as a temporary patch to allow our CI to run.

@neutrinoceros neutrinoceros added bug blocker Highest priority level infrastructure Related to CI, versioning, websites, organizational issues, etc labels Sep 7, 2021
@neutrinoceros neutrinoceros mentioned this pull request Sep 7, 2021
Closed
@neutrinoceros
Copy link
Member Author

So this is a success because it fixes the issue addressed (install stage is now go). The job is still failing because of yet another, yet unidentified upstream change, but seemingly this is specific to macOS, so let's try deactivating as a sanity check.

@neutrinoceros neutrinoceros changed the title MNT: hotfix CI by setting an upper limit to setuptools version MNT: hotfix CI Sep 7, 2021
@neutrinoceros neutrinoceros marked this pull request as draft September 8, 2021 08:34
@neutrinoceros
Copy link
Member Author

setuptools 58.0.3 was released a couple hours ago and should resolve the problem, so I'm reverting the initial hotfix. Also this a draft since currently the only net effect of this PR isn't what's described in the OP

@neutrinoceros
Copy link
Member Author

Alright so the newest setuptools version still breaks our CI. I believe this time it can be considered intentional as they are actively removing support for packages using the use_2to3 flag. This seems like an opportunity to bumps some of our "minimal" requirements. IPython 1.0.0 was released 8 years ago, I think it's now okay to require a more recent version, so let's try that.

@neutrinoceros
Copy link
Member Author

It may be okay to reactivate macOS now that actions/runner-images#4020 was closed.

@neutrinoceros
Copy link
Member Author

At last, everything is now working, but this PR has 5 commits (which I'm going to keep as "documentation" of what happened), 4 of which are mutually cancelling, so I'm going to open a different PR with only the last relevant commit. I'll close this one once CI goes full green.

@neutrinoceros neutrinoceros mentioned this pull request Sep 8, 2021
Merged
@neutrinoceros neutrinoceros deleted the hotfix_ci_setuptools branch September 8, 2021 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
blocker Highest priority level bug infrastructure Related to CI, versioning, websites, organizational issues, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@neutrinoceros