BUG: remove broken logging messages in lens module #3548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
added
bug
dead code
|
The py38 job is going to break because of this: sympy/sympy#22241 |
|
@neutrinoceros So if we include this will it continue to break the py38 tests, or are they broken already? |
|
they are broken for external reasons following the release of sympy 1.9, they will stay broken until a bug fix is released upstream or we pin sympy to 1.8 in CI. |
chrishavlin
approved these changes
Oct 11, 2021
|
@yt-fido test this please |
This was referenced Oct 12, 2021
|
@meeseeksdev backport to yt-4.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/yt
that referenced
this pull request
Oct 15, 2021
neutrinoceros
added a commit
that referenced
this pull request
Oct 16, 2021
…8-on-yt-4.0.x Backport PR #3548 on branch yt-4.0.x (BUG: remove broken logging messages in lens module)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #3547
My original intent was to fix the formatting of these log entries, but our logger filters are performing object comparisons
at runtime, which are very costly to run on numpy/unyt arrays (*would be, since they'd require some changes to even work here), so I don't think it's actually worth keeping these logging entries that no ones has been relying on for at least a year, since we introduced logger filters in #2871