Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: fix an off-by-one error in ColorTransferFunction.to_map_colormap method #3661

Merged
merged 1 commit into from
Nov 10, 2021
Merged

BUG: fix an off-by-one error in ColorTransferFunction.to_map_colormap method #3661

merged 1 commit into from
Nov 10, 2021

Conversation

neutrinoceros
Copy link
Member

@neutrinoceros neutrinoceros commented Nov 10, 2021 •
edited
Loading

PR Summary

Fix #3660

rerunning the script therein I obtain:

[1. 1. 1. 1. 1. 1. 1. 1.]
[0.96862745 0.8584083  0.73094963 0.53568627 0.32628989 0.16696655
 0.04405998 0.03137255]
[0.98431373 0.91344867 0.83947712 0.74608228 0.61862361 0.48069204
 0.33388697 0.18823529]
[1.         0.96456747 0.92132257 0.86425221 0.80279892 0.72915033
 0.62445213 0.41960784]

output

matthewturk
matthewturk approved these changes Nov 10, 2021
View reviewed changes
Copy link
Member

@matthewturk matthewturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is right. Thanks!

@neutrinoceros neutrinoceros mentioned this pull request Nov 10, 2021
Closed
42 tasks
@matthewturk matthewturk merged commit 747d435 into yt-project:main Nov 10, 2021
@neutrinoceros neutrinoceros deleted the hotfix_3660 branch November 10, 2021 12:13
@neutrinoceros
Copy link
Member Author

@meeseeksdev backport to yt-4.0.x

meeseeksmachine pushed a commit to meeseeksmachine/yt that referenced this pull request Nov 10, 2021
@matthewturk @meeseeksmachine
Backport PR yt-project#3661: BUG: fix an off-by-one error in ColorTra…
570c16a 
…nsferFunction.to_map_colormap method
@meeseeksmachine meeseeksmachine mentioned this pull request Nov 10, 2021
Merged
matthewturk added a commit that referenced this pull request Nov 12, 2021
@matthewturk
Merge pull request #3662 from meeseeksmachine/auto-backport-of-pr-366…
ab4be6b 
…1-on-yt-4.0.x

Backport PR #3661 on branch yt-4.0.x (BUG: fix an off-by-one error in ColorTransferFunction.to_map_colormap method)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewturk matthewturk matthewturk approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Colortransferfunction map_to_colormap makes last values for all channels zero
2 participants
@neutrinoceros @matthewturk