Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: hotfix iterative plot annotations #4160

Merged
merged 2 commits into from
Oct 13, 2022

Conversation

neutrinoceros
Copy link
Member

PR Summary

Fix 2 regressions from #3957 :

  • BUG: fix a regression where adding plot annotations would not invalidate plot
  • BUG: fix a regression where calling plot annotation method would not trigger new render in interactive notebooks

Closes #4159

@neutrinoceros
Copy link
Member Author

neutrinoceros commented Oct 10, 2022

It still need slight adjustments because it degrades the error message designed in #3957

edit: never mind, nothing's really changed, I was just comparing results with Python 3.8 against a reference done with Python 3.10

@neutrinoceros neutrinoceros marked this pull request as ready for review October 10, 2022 15:45
@neutrinoceros neutrinoceros changed the title BUG: hotfix interactive plot annotations BUG: hotfix iterative plot annotations Oct 10, 2022
@chrishavlin chrishavlin merged commit fc8226e into yt-project:main Oct 13, 2022
meeseeksmachine pushed a commit to meeseeksmachine/yt that referenced this pull request Oct 13, 2022
@neutrinoceros neutrinoceros deleted the hotfix_annotations branch October 13, 2022 14:44
neutrinoceros added a commit that referenced this pull request Oct 14, 2022
…0-on-yt-4.1.x

Backport PR #4160 on branch yt-4.1.x (BUG: hotfix iterative plot annotations)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: iterative plot annotations are broken
2 participants