Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix order of Athena++ cylindrical coords #4801

Merged
merged 5 commits into from
Feb 15, 2024
Merged

Fix order of Athena++ cylindrical coords #4801

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f9a9543
WIP: Fix order of cylindrical coords, GR broke
Feb 1, 2024
4c48783
Cleanup fix, make less intrusive. GR untouched
Feb 2, 2024
4e5cce3
Update yt/frontends/athena_pp/data_structures.py
forrestglines Feb 5, 2024
4d7f493
Merge branch 'main' into fix-athena_pp-cylindrical-order
Feb 5, 2024
2aba96b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions yt/frontends/athena_pp/data_structures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,13 +153,22 @@ def __init__(
zrat = self._handle.attrs["RootGridX3"][2]
self._nonuniform = xrat != 1.0 or yrat != 1.0 or zrat != 1.0
self._magnetic_factor = get_magnetic_normalization(magnetic_normalization)

geom = self._handle.attrs["Coordinates"].decode("utf-8")
self.geometry = Geometry(geom_map[geom])
matthewturk marked this conversation as resolved.
Show resolved Hide resolved
if self.geometry == "cylindrical":
axis_order = ("r", "theta", "z")
else:
axis_order = None

Dataset.__init__(
self,
filename,
dataset_type,
units_override=units_override,
unit_system=unit_system,
default_species_fields=default_species_fields,
axis_order=axis_order,
)
if storage_filename is None:
storage_filename = self.basename + ".yt"
Expand Down Expand Up @@ -200,9 +209,6 @@ def _parse_parameter_file(self):
self.domain_left_edge = np.array([xmin, ymin, zmin], dtype="float64")
self.domain_right_edge = np.array([xmax, ymax, zmax], dtype="float64")

self.geometry = Geometry(
geom_map[self._handle.attrs["Coordinates"].decode("utf-8")]
)
self.domain_width = self.domain_right_edge - self.domain_left_edge
self.domain_dimensions = self._handle.attrs["RootGridSize"]

Expand Down
Loading