Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin xradar<0.8.0 in tests #5042

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

chrishavlin
Copy link
Contributor

This is a temporary fix for #5041 on yt's side that should get tests passing but will need to be updated when a fix on the the arm-pyart side is released (at which point we could pin a min version for arm-pyart for the tests).

@chrishavlin chrishavlin added bug infrastructure Related to CI, versioning, websites, organizational issues, etc dependencies Pull requests that update a dependency file labels Nov 5, 2024
@chrishavlin
Copy link
Contributor Author

chrishavlin commented Nov 5, 2024

just to summarize the confusing dependency resolution (and why I just pinnned xradar here):

  • as of this writing arm-pyart (v 1.16.1) depends explicitly on xarray, xradar and implicitly on xarray-datatree (which installs as datatree)
  • xradar also depends on xarray-datatree
  • xarray-datatree is now deprecated and has been moved to xarray >= 2024.10.0
  • xradar >= 0.8.0 requires xarray >= 2024.10.0 to account for the xarray-datatree deprecation, xradar < 0.8 relies on the deprecated xarray-datatree

So effectively arm-pyart currently has both a hard dependency on xradar < 0.8.0 and xarray-datatree and just pinning xradar < 0.8.0 is sufficient for yt's tests.

Moving forward, the simplest thing to do will be to replace the change in this PR with a test requirement on arm-pyart >= 1.16.2 after it is released (and assuming it contains a fix).

@neutrinoceros
Copy link
Member

Thanks a lot for the write up, I was really confused by this situation.

@neutrinoceros neutrinoceros added tests: running tests Issues with the test setup and removed infrastructure Related to CI, versioning, websites, organizational issues, etc labels Nov 6, 2024
@neutrinoceros neutrinoceros merged commit edae4e0 into yt-project:main Nov 6, 2024
13 checks passed
@neutrinoceros neutrinoceros added this to the 4.4.0 milestone Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dependencies Pull requests that update a dependency file tests: running tests Issues with the test setup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants