-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YTEP-0039: Rich Terminal User Interface #18
Conversation
I like this a lot. Need to think about what default is for next release -- maybe gradual phase-in? |
Yeah it could be added in time for 4.0 as an experimental feature and only made the default in 4.2 😃 |
8d225f9
to
286823c
Compare
de33003
to
8616b6c
Compare
8616b6c
to
6470d8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I like this quite a bit and it doesn't seem to be as invasive a change as I originally perceived. I'm quite intrigued by the idea of multiple concurrent progress bars mixed with logging messages. This could be neat for some parallel operations. I'm happy to accept this and for the corresponding yt PRs to go ahead.
I am tempted to drop this YTEP entirely for the following reasons:
@matthewturk, I suppose I should I mark this YTEP as "rejected", then we can merge this PR for posterity ? |
Not yet? Can I read carefully before you do anything? |
As you wish, but I TBH I don't think it's worth any more of anyone's time. |
Sorry Matt I just can't keep circling back to this. I've marked the YTEP as withdrawn, and I'll close my associated PRs on the yt side. |
I'll just merge myself here, as I can't think of any other route to go with a withdrawn proposal. The document only has a historical value now so there's no reason to change it anymore. I hope that's okay with everyone. |
TLDR: I propose replacing our logging handler with
rich
's version for it, and expose other potential applications for this library in yt.Much more detail awaits in yt-project/yt#3106, but this YTEP specifies the new configuration parameters.
Here are the embedded illustrations to help visualise the proposed change for yt's logger
From a notebook
Legacy
Rich
From a terminal
Legacy
Rich