release 2014.11.23.1 · ytdl-org/youtube-dl@835a22e · GitHub

Commit

release 2014.11.23.1

Browse files

Loading branch information

phihag committed Nov 23, 2014

1 parent 7d4111e commit 835a22e

youtube_dl/version.py

Original file line number	Diff line number	Diff line change
		@@ -1,2 +1,2 @@

		__version__ = '2014.11.23'
		__version__ = '2014.11.23.1'

3 comments on commit `835a22e`

Nailzy commented on `835a22e` Nov 23, 2014

Great work guys. You chaps are always ontop of everything here.

Any chance on helping us out getting the XBMC Youtube plugin fixed with the sig stuff changing recently?

Contributor Author

phihag commented on `835a22e` Nov 23, 2014

Thanks! Um, if you are having an issue with youtube-dl (is XBMC using it under the covers?), can you point us to the issue entry?

Nailzy commented on `835a22e` Nov 24, 2014

Hi Phil!

Thanks for replying. I don't believe they are using it under the covers explicitly but obviously there are similarities. Before there was an algo put into their plugin for signature extraction - I used to be able to fix it myself by waiting for you guys to be ahead of the game - and just use the new sig info and modify it (just for myself obviously)

However recently - the plugin has been suffering from lots of bugs / issues with all the changes being made and I don't think the people responsible for the plugin are very active at all - which is a shame given that the Youtube addon is one of the flagship addons for Kodi.

My issue is posted at HenrikDK/youtube-xbmc-plugin#88 - you can see from the error log that the signature isn't being pulled. Another issue log is HenrikDK/youtube-xbmc-plugin#85

The original fix to the problem about a week ago was simple - but even that no longer works. The patch was this :

--- a/YouTubePlayer.py
+++ b/YouTubePlayer.py
@@ -467,7 +467,7 @@ class YouTubePlayer():
return ''

         # get main function name

       match = re.search("signature=([$a-zA-Z]+)([^)])", playerData)

       match = re.search("set..signature..([$a-zA-Z]+)\([^)]\)", playerData)

     if match:
         mainFunName = match.group(1)

Any help / guidance you can provide would be much appreciated if you have the time (and are of course... allowed to!!)

Please sign in to comment.