Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thumbnail support for PeerTube #28419

Closed
3 tasks done
christoph-heinrich opened this issue Mar 12, 2021 · 1 comment · Fixed by rafaelurben/django-discordbot#86, tomy0000000/tubee#15, natanlao/yaas#21, kijk2869/discodo#156 or etnguyen03/docker-tubeup#59
Closed
3 tasks done

Thumbnail support for PeerTube #28419

christoph-heinrich opened this issue Mar 12, 2021 · 1 comment · Fixed by rafaelurben/django-discordbot#86, tomy0000000/tubee#15, natanlao/yaas#21, kijk2869/discodo#156 or etnguyen03/docker-tubeup#59

Comments

@christoph-heinrich
Copy link

Checklist

  • I'm reporting a site feature request
  • I've verified that I'm running youtube-dl version 2021.03.03
  • I've searched the bugtracker for similar site feature requests including closed ones

Description

I would like to have support for downloading and embedding thumbnails for videos on PeerTube instances.

In the HTML of the site in the <head> there are three <meta> tags

  1. property="image"
  2. property="og:image"
  3. property="twitter:image"

each has a content attribute that contains the thumbnail url.
I have checked multiple PeerTube instances and this seems to be the case for all of them.

So for example this video would have the tag
<meta property="image" content="https://gegenstimme.tv/lazy-static/previews/77b5b0ea-eca1-465e-a6bd-c96dfa11ded7.jpg" />
@christoph-heinrich
Copy link
Author

Thank you for that fix, although there is one more thing I'd like you to change here.
Currently the url to the thumbnail is taken from thumbnailPath, however a bigger version of that thumbnail is available in the same json under previewPath. Simply changing that one string in line 608 should be enough.
Since the highest quality thumbnail is taken from youtube, i figured we might want to do the same with PeerTube.

github-actions bot added a commit to hellopony/youtube-dl that referenced this issue Mar 12, 2021
@github-actions
[bot] AutoMerging: merge all upstream's changes:
80370cb 
* https://github.com/ytdl-org/youtube-dl:
  [pinterest] reduce the number of HLS format requests
  [peertube] improve thumbnail extraction(closes ytdl-org#28419)
  [tver] improve title extraction(closes ytdl-org#28418)
  [fujitv] fix HLS formats extension(closes ytdl-org#28416)
This was referenced Mar 15, 2021
Merged
Closed
Merged
Merged
Closed
Closed
Merged
Merged
Merged
Closed
Merged
Closed
Closed
Merged
Merged
Merged
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
leshasmlesha pushed a commit to leshasmlesha/youtube-dl that referenced this issue Apr 3, 2021
@remitamine @leshasmlesha
[peertube] improve thumbnail extraction(closes ytdl-org#28419)
acc4f41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@christoph-heinrich