-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YouTube annotations support #6531
Comments
I've tried ytanno2ass.py against https://www.youtube.com/watch?v=C5zzVemi3m4, and it gives the following error:
The developer instructions may be helpful if you're going to work on this feature. Note that we require all codes compatible with python 2.6, 2.7, 3.2, 3.4. |
I worked on it a bit more and fixed that and a few other unrelated bugs, though text wrapping is still totally broken. I didn't add support for those missing annotation types since they involve images and the ASS renderer has no way of inserting raster graphics that I know of. I don't plan to work on maintaining this full-time, sorry. It was just a fun little project for me and figured maybe someone more experienced could integrate it once the implementation was more or less done.. |
Would you like to release Tkinter is not a big issue as it's a python builtin module. |
Well, I'd need to rewrite the word wrapping function, I guess. How would one go about releasing code public domain? |
A common approach is to add some comments in the file. Here's an example: pyelftools |
Rewrote the word wrap function so all the code is written by me and made it public domain. |
As of now, isn't annotations supported? Should this be closed? |
It supports converting subtitles to SRT and can write out the annotations XML, but it as far as I can tell, looking over the command line options, it can't output annotations in a way a media player can use them. |
YouTube will delete existing video annotations on January 15, 2019. This would imply Youtube annotation support can be deprecated after that date. |
Invidious may decide to implement annotations and serve backed up annotations themselves. |
See iv-org/invidious#303 and the announcement here. There's currently a temporary API for serving up what's been archived until everything has been uploaded to archive.org. This endpoint now returns an empty response for videos that used to have legacy annotations. |
See also #19069. Pulling annotations from a different source is considered (understandably) out-of-scope for this project. |
Oh hey, my PR! |
Close this. It’s a removed feature. |
I was wondering how possible it'd be to integrate youtube annotations support in to youtube-dl. I know it would be a big undertaking but I have done a good bit of the work. I don't really know how to integrate it with youtube-dl myself and it has some problems that maybe someone more experienced at python or programming or youtube or whatever else might be able to get stuff going and get it in to youtube-dl.
Here's my code: https://github.com/paulguy/minitools/blob/master/ytanno2ass.py
The README in that repository gives a bit more information on the limitations and problems with it.
The text was updated successfully, but these errors were encountered: