Apply fixups to individual streams (fixes #10644/#9913) #10645
Closed
+80
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnpatch
changed the title
|
this fixes my bug too but it may seem that the final filename returned by the progress hook is wrong. |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't very pretty as it calls post_process multiple times, so _pps needs to be cleared temporarily to avoid duplicate processing. Maybe someone has a more elegant solution?
In the case where
info_dict['protocol'] == 'm3u8'inprocess_info, FFmpegFixupM3u8PP may be applied multiple times: once for each stream, and once for the whole file. I don't know if it can happen, or if it's a problem if it happens. Perhaps we don't need to apply it to the whole file.Note that in the example from #10644,
new_info['protocol'] == 'm3u8'for the audio stream butinfo_dict['protocol']is not set, so that problem does not appear.