Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vivo] use ROT47 instead of base64 to decode the stream url #22279

Closed
wants to merge 1 commit into from
Closed

[vivo] use ROT47 instead of base64 to decode the stream url #22279

wants to merge 1 commit into from

Conversation

waahhhh
Copy link

@waahhhh waahhhh commented Aug 31, 2019

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

vivo.sx doesn't encode the stream url with base64 anymore. ROT47 is used.
The test video is not available, so I updated the test, too.

@waahhhh waahhhh mentioned this pull request Sep 15, 2019
@lucas1
Copy link

lucas1 commented Sep 24, 2019

Work good, thanks

@OfficialCRUGG OfficialCRUGG mentioned this pull request Oct 6, 2019
5 tasks
@OfficialCRUGG
Copy link

Is this ever going to get merged? I need vivo.sx downloading as quick as possible.

@Yasamato
Copy link

Can someone merge this or at least tag this as pending-fixes?

@byteholding
Copy link

please merge.

thanks!

@byteholding
Copy link

It has been changed again. Therefore please do not merge yet!

@waahhhh
Copy link
Author

waahhhh commented Oct 26, 2019

The js object structure has been changed.
I'm not really proud of the current solution to expect, that the attribute "preroll" has to follow the attribute "source".
Maybe we could parse the js object by a module like https://stackoverflow.com/a/26900181.

But currently it works again.

@byteholding
Copy link

Wow amazing. thank you!

@byteholding
Copy link

Hey @waahhhh,

since a few minutes the vivo addon does not work again.
Could you please check again if you can find a solution?

@waahhhh
Copy link
Author

waahhhh commented Nov 16, 2019

Updated the regex again. Also solved the issue that the attributes of the object structure need a certain order.

@MrIcedTea
Copy link

ping!!!

@MrIcedTea MrIcedTea mentioned this pull request Nov 23, 2019
5 tasks
@dstftw dstftw closed this in edc2a1f Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants