Get HD formats for Reel #28332
Get HD formats for Reel #28332
Conversation
|
no, using the default |
|
I thought it would and that was my first pass, but it didn't work for me. It does when (logically enough) the value was set before Presumably there's a good reason why this isn't the default for BBCIE, relative to the comment at https://github.com/dirkf/youtube-dl/blob/49d83ee5022be269dbacc5e1300d331350f1a125/youtube_dl/extractor/bbc.py#L54. Is this robust against failing to fetch the Is there a danger of returning formats that the user can't actually reach? |
youtube_dl/extractor/bbc.py
Outdated
| programme_id = self._search_regex( | ||
| r'/reel/video/(?P<id>%s)/' % self._ID_REGEX, url, 'Reel pid', default=None) |
| formats, subtitles = self._download_media_selector(version_id) | ||
| self._sort_formats(formats) | ||
| image_url = smp_data.get('holdingImageURL') | ||
| display_date = init_data.get('displayDate') | ||
| topic_title = init_data.get('topicTitle') | ||
|
|
| # also try for higher resolutions | ||
| self._MEDIA_SETS.insert(0, 'iptv-all') |
There was a problem hiding this comment.
as the iptv-all gives better quality in general, just drop _MEDIA_SETS from the extractor and just use the default value from BBCCoUkIE.
|
Please kindly consider what's detailed in #21870 (comment) ; thanks in advance! |
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Per #21870 (comment), we don't get the highest resolution formats through the
BBCIEextractor. This patch gets the metadata that is available from the Reel page and then uses theurl_transparentmechanism to get the formats, which now include 1280x720 as well as the 960x540 and lower available from the BBCIE extractor.