[doodstream] add new extractor #28903
Open
+60
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schnusch
force-pushed
the
doodstream
branch
2 times, most recently
from
01ab714 to
bd9d5cb
Compare
rautamiekka
reviewed
Apr 30, 2021
youtube_dl/extractor/doodstream.py
Outdated
| auth_url = urljoin(url, auth_url) | ||
|
|
||
| webpage = self._download_webpage(auth_url, video_id, headers=referer) | ||
| final_url = webpage + ''.join([random.choice(string.ascii_letters + string.digits) for _ in range(10)]) + "?token=" + token + "&expiry=" + str(int(time.time() * 1000)) |
There was a problem hiding this comment.
You don't need to specify a list comprehension for ''.join(), a generator comprehension is faster anyway (implied inside parenthesis), and uses far less RAM.
* metadata
* fetch and decrypt video title
* implemented doodExe
* add filesize and duration
* removed description
* use _og_search_thumbnail
* remove User-Agent from HTTP headers because it is not needed
|
Read coding conventions. |
|
I am not sure what you mean specifically. Can you point me in a direction? |
|
If I'm remember, single quotes: |
|
This is an interesting PR. Is this something that is being worked on still? |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
This supersedes #28008 and therefore obsoletes sxvghd#1.
Closes #28008.