Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update youtube.py #30379

Closed
wants to merge 2 commits into from
Closed

Conversation

jedhelmers
Copy link

@jedhelmers jedhelmers commented Dec 15, 2021

I took a swing and it seems to be working with mp3. I'm kind of stunned haha. Anywho...
1.) updated youtube.py to check for 2 or 3 chars in regex

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible.

I took a swing and it seems to be working with mp3. I'm kind of stunned haha. Anywho...
1.) updated youtube.py to check for 2 or 3 chars in regex
@lanegramling
Copy link

This PR is a duplicate of #30366. (That being said, this is the correct fix and it should work).

Copy link
Contributor

@dirkf dirkf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a) This won't work

>>> import re
>>> re.findall(r'\d{2|3}', 'a22bc')
[]
>>> re.findall(r'\d{2|3}', 'a223bc')
[]
>>> re.findall(r'\d{2,}', 'a223bc')
['223']
>>> 

b) @lanegramling already submitted a working PR for this issue and @dstfw merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants