[YouPorn] Fix and improve extraction; add playlist extraction #32740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkf
changed the title
dirkf
commented
Mar 10, 2024
* from yt-dlp/yt-dlp#8827 * extract from webpage instead of broken API URL * thx The-MAGI
* parallel to `playlist_mincount' * specify both for a range of playlist lengths * if max < min the test will always fail!
dirkf
force-pushed
the
df-youporn-extractor-ovrhaul
branch
2 times, most recently
from
53d0f6c to
5c9636c
Compare
* detect unwatchable videos * improve duration extraction * fix count extraction and support large values * detect and remove SEO spam boilerplate description
* YouPornCategoryIE * YouPornChannelIE * YouPornCollectionIE * YouPornStarIE * YouPornTagIE * YouPornVideosIE,
dirkf
force-pushed
the
df-youporn-extractor-ovrhaul
branch
from
5c9636c to
f66e450
Compare
dirkf
changed the title
|
If your program is yt-dlp, it won't (yet) have this PR code. Review #30839 and the yt-dlp home page. Regarding |
|
It turns out I'd initially confused youtube-dl with yt-dlp. Yesterday, the fix has been merged into the latter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boilerplate: own/yt-dlp code, bug fix/improvement
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
This PR aligns the YouPorn extractor with yt-dlp extractor and fixes the problem reported in yt-dlp/yt-dlp#7967. It also adds playlist extractors.
Summary of changes to the
YouPornIEezxtractor:traverse_obj()descriptionthat is not automatically generated from thetitle.The playlist extractors are:
The site's processing of playlist URLs appears to be broken in various ways, especially for tags. A work-around is included to delay and retry in case a tag page is empty or appears to be the same as the last page fetched, with which the extractor seems robust.