-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YouTube] Fix nsig challenge for player 3bb1f723
#32987
Open
dirkf
wants to merge
14
commits into
ytdl-org:master
Choose a base branch
from
dirkf:df-youtube-32986
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+636
−202
Open
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
af7c0ff
[InfoExtractor] Use kwarg maxsplit for re.split
dirkf 7e93935
[jsinterp] Implement `typeof` operator
dirkf 527c137
[jsinterp] Fix and improve loose and strict equality operations
dirkf 7d3045c
[jsinterp] Support multiple indexing (eg a[1][2])
dirkf 9993e8c
[jsinterp] Fix and improve arithmetic operations
dirkf 4bf85ca
[jsinterp] Fix and improve split/join
dirkf 7ab85d8
[jsinterp] Fix and improve "methods"
dirkf 067ad74
[jsinterp] Strip /* comments */ when parsing
dirkf 2968201
[jsinterp] Add return hook for player `3bb1f723`
dirkf a93fff3
[YouTube] Handle player `3bb1f723`
dirkf 9bc8fcf
[YouTube] Pass nsig value as return hook, fixes player `3bb1f723`
dirkf 3d64984
[YouTube] Simplify pattern for nsig function name extraction
dirkf 82b5256
[YouTube] Fix signature function extraction for `2f1832d2`
dirkf 12bc377
[YouTube] Always extract using MWEB API client
dirkf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "False and" looks like a temporary stopgap. It could thus use an inline comment explaining where to read about what problem it mitigates and what work is needed to fix it properly. Ideally the explanation would be a link to an issue thread.
Edit: Now seeing the "True or" a few lines ahead, it may be better to just set
player_response = False
and mark that as the stopgap, rather than having two bogus conditions.Anyway, thanks for your great work! 👍