Add --socks-proxy parameter to use socks proxy #6353
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the user to specify a socks proxy to tunnel the connection through.
Closed
|
This approach forces all network traffic going through the SOCKS proxy. The urllib2 handler approach might be better. |
added 6 commits
July 25, 2015 18:36
|
Why is it a bad thing if all traffic goes through the proxy? Which traffic do you want bypassing the proxy? |
|
I think I nearly got it. Will update this PR tomorrow. |
|
As already mentioned in IRC conversation you should ensure there are no problems bundling SocksiPy with py2exe in the first place. |
Closes #6370.
That's how YouTube reports them in their DASH manifest.
This allows the user to specify a socks proxy to tunnel the connection through. This feature requires that PySocks is available. If the user tries to use a SOCKS proxy without PySocks available an error is printed and the process is aborted.
This allows the user to specify a socks proxy to tunnel the connection through. This feature requires that PySocks is available. If the user tries to use a SOCKS proxy without PySocks available an error is printed and the process is aborted.
|
Sorry about all the commits. I'm going to close this one and create a new clean PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #402
This allows the user to specify a socks proxy to
tunnel the connection through.
This does add a soft dependency on socksipy. Normal operation will work without it,
but socks support obviously depends on it.
I did some positive tests and a videos were downloaded from youtube via the socks proxy.
I did not test other hosts, but assume it should work the same.
I am not certain what happens if --socks-proxy and --proxy are specified simultaneously. Did not have a http proxy to test this.
The unittests have not finished running yet, but since none of my code (except adding the option) is actually run if the --socks-proxy option is not set it seems highly unlikely for it break existing functionality.