supporting PartialKeyMatch for SetNode

ythadhani · May 20, 2022 · b62ada1 · b62ada1
1 parent eb6a865
commit b62ada1
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 15 deletions.
diff --git a/ytypes/node.go b/ytypes/node.go
@@ -446,7 +446,7 @@ func GetNode(schema *yang.Entry, root interface{}, path *gpb.Path, opts ...GetNo
 	return retrieveNode(schema, root, path, nil, retrieveNodeArgs{
 		// We never want to modify the input root, so we specify modifyRoot.
 		modifyRoot:       false,
-		partialKeyMatch:  hasPartialKeyMatch(opts),
+		partialKeyMatch:  hasGetNodePartialKeyMatch(opts),
 		handleWildcards:  hasHandleWildcards(opts),
 		preferShadowPath: hasGetNodePreferShadowPath(opts),
 	})
@@ -458,19 +458,34 @@ type GetNodeOpt interface {
 	IsGetNodeOpt()
 }
 
-// GetPartialKeyMatch specifies that a match within GetNode should be allowed to partially match
-// keys for list entries.
-type GetPartialKeyMatch struct{}
+// PartialKeyMatch specifies that a match within GetNode or SetNode should be allowed to partially
+// match keys for list entries.
+type PartialKeyMatch struct{}
 
 // IsGetNodeOpt implements the GetNodeOpt interface.
-func (*GetPartialKeyMatch) IsGetNodeOpt() {}
+func (*PartialKeyMatch) IsGetNodeOpt() {}
 
-// hasPartialKeyMatch determines whether there is an instance of GetPartialKeyMatch within the supplied
+// IsSetNodeOpt implements the SetNodeOpt interface.
+func (*PartialKeyMatch) IsSetNodeOpt() {}
+
+// hasGetNodePartialKeyMatch determines whether there is an instance of PartialKeyMatch within the supplied
 // GetNodeOpt slice. It is used to determine whether partial key matches should be allowed in an operation
 // involving a GetNode.
-func hasPartialKeyMatch(opts []GetNodeOpt) bool {
+func hasGetNodePartialKeyMatch(opts []GetNodeOpt) bool {
+	for _, o := range opts {
+		if _, ok := o.(*PartialKeyMatch); ok {
+			return true
+		}
+	}
+	return false
+}
+
+// hasSetNodePartialKeyMatch determines whether there is an instance of PartialKeyMatch within the supplied
+// SetNodeOpt slice. It is used to determine whether partial key matches should be allowed in an operation
+// involving a SetNode.
+func hasSetNodePartialKeyMatch(opts []SetNodeOpt) bool {
 	for _, o := range opts {
-		if _, ok := o.(*GetPartialKeyMatch); ok {
+		if _, ok := o.(*PartialKeyMatch); ok {
 			return true
 		}
 	}
@@ -516,6 +531,7 @@ func SetNode(schema *yang.Entry, root interface{}, path *gpb.Path, val interface
 		val:                               val,
 		tolerateJSONInconsistenciesForVal: hasTolerateJSONInconsistencies(opts),
 		preferShadowPath:                  hasSetNodePreferShadowPath(opts),
+		partialKeyMatch:                   hasSetNodePartialKeyMatch(opts),
 	})
 	if err != nil {
 		return err

diff --git a/ytypes/node_test.go b/ytypes/node_test.go
@@ -1458,7 +1458,7 @@ func TestGetNode(t *testing.T) {
 			},
 		},
 		inPath: mustPath("/list"),
-		inArgs: []GetNodeOpt{&GetPartialKeyMatch{}},
+		inArgs: []GetNodeOpt{&PartialKeyMatch{}},
 		wantTreeNodes: []*TreeNode{{
 			Data:   &listEntry{Key: ygot.String("one")},
 			Schema: simpleListSchema,
@@ -1474,7 +1474,7 @@ func TestGetNode(t *testing.T) {
 			},
 		},
 		inPath: mustPath("/list"),
-		inArgs: []GetNodeOpt{&GetPartialKeyMatch{}},
+		inArgs: []GetNodeOpt{&PartialKeyMatch{}},
 		wantTreeNodes: []*TreeNode{{
 			Data:   &listEntry{Key: ygot.String("one")},
 			Schema: simpleListSchema,
@@ -1629,7 +1629,7 @@ func TestGetNode(t *testing.T) {
 			},
 		},
 		inPath: mustPath("/multilist[keyone=1]"),
-		inArgs: []GetNodeOpt{&GetPartialKeyMatch{}},
+		inArgs: []GetNodeOpt{&PartialKeyMatch{}},
 		wantTreeNodes: []*TreeNode{{
 			Data:   &multiListEntry{Keyone: ygot.Uint32(1), Keytwo: ygot.Uint32(2)},
 			Schema: multiKeyListSchema,
@@ -1981,7 +1981,8 @@ func TestSetNode(t *testing.T) {
 				LeaflistVal: &gpb.ScalarArray{
 					Element: []*gpb.TypedValue{
 						{Value: &gpb.TypedValue_IntVal{IntVal: 42}},
-					}},
+					},
+				},
 			}},
 			inOpts:   []SetNodeOpt{&InitMissingElements{}},
 			wantLeaf: []int32{42},
@@ -2008,7 +2009,8 @@ func TestSetNode(t *testing.T) {
 				LeaflistVal: &gpb.ScalarArray{
 					Element: []*gpb.TypedValue{
 						{Value: &gpb.TypedValue_IntVal{IntVal: 43}},
-					}},
+					},
+				},
 			}},
 			inOpts:   []SetNodeOpt{&InitMissingElements{}},
 			wantLeaf: []int32{43},

diff --git a/ytypes/schema_tests/get_test.go b/ytypes/schema_tests/get_test.go
@@ -143,7 +143,7 @@ func TestGetNodeFull(t *testing.T) {
 		}(),
 		inSchema: rootSchema,
 		inPath:   mustPath("/interfaces/interface/config/description"),
-		inOpts:   []ytypes.GetNodeOpt{&ytypes.GetPartialKeyMatch{}},
+		inOpts:   []ytypes.GetNodeOpt{&ytypes.PartialKeyMatch{}},
 		wantNodes: []*ytypes.TreeNode{{
 			Path: mustPath("/interfaces/interface[name=eth0]/config/description"),
 			Data: ygot.String("eth0"),
@@ -161,7 +161,7 @@ func TestGetNodeFull(t *testing.T) {
 		}(),
 		inSchema: rootSchema,
 		inPath:   mustPath("/interfaces/interface"),
-		inOpts:   []ytypes.GetNodeOpt{&ytypes.GetPartialKeyMatch{}},
+		inOpts:   []ytypes.GetNodeOpt{&ytypes.PartialKeyMatch{}},
 		wantNodes: []*ytypes.TreeNode{{
 			Path: mustPath("/interfaces/interface[name=eth0]"),
 			Data: &oc.Interface{