Fix missing output from routeros version command (#2475)

* Output of a command needs to be the last line of a block * Update CHANGELOG.md
ytti · Mar 10, 2022 · d67aceb · d67aceb
1 parent c39cc09
commit d67aceb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -61,7 +61,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
 - <?xml... line is no longer improperly stripped from OPNsense and PFsense backups (@pv2b)
 - fixed an issue where Oxidized timeouts in Brocade ICX-series devices (@piterpunk)
 - fixed an issue where EOS config was truncated. Fixes #2038 (@jake2184 @fhibler)
-
+- fixed missing output from routeros version command (@mjbnz)
 
 ## [0.28.0 - 2020-05-18]
 

diff --git a/lib/oxidized/model/routeros.rb b/lib/oxidized/model/routeros.rb
@@ -19,8 +19,8 @@ class RouterOS < Oxidized::Model
 
   cmd '/system package update print without-paging' do |cfg|
     version_line = cfg.each_line.grep(/installed-version: /)[0]
-    comment version_line
     @ros_version = /: ([0-9])/.match(version_line)[1].to_i
+    comment version_line
   end
 
   cmd '/system history print without-paging' do |cfg|