Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prompt for Watchguard FirewareOS not matching the Regex when the node is non-master #2779

Closed
netdiver opened this issue May 5, 2023 · 1 comment · Fixed by #2780
Closed

Prompt for Watchguard FirewareOS not matching the Regex when the node is non-master #2779

netdiver opened this issue May 5, 2023 · 1 comment · Fixed by #2780

Comments

@netdiver
Copy link
Contributor

netdiver commented May 5, 2023 •
edited
Loading

This is related to issue #1063

Any non master node in a Fireware cluster has a prompt containing the <non-master> text.
E.g my non master node has this prompt in this moment:

[FAULT]WG<non-master>>

The configured Regex in firewareos.rb:
^\[?\w*\]?\w*?(<\w*>)?(#|>)\s*$
cannot capture this prompt because of the dash into the <non-master> section.

Changing the Regex to

^\[?\w*\]?\w*?(<[\w-]*>)?(#|>)\s*$

seems to solve the issue.

I put this regex into a modified firewareos.rb file in the config/model directory to override the default one, and it works for the master and non-master node of the cluster.

Regards
Lorenzo
@netdiver netdiver mentioned this issue May 5, 2023
Merged
@netdiver
Copy link
Contributor Author

netdiver commented May 5, 2023

I hope my pull request is correct.

@ghost ghost closed this as completed in #2780 May 17, 2023
ghost pushed a commit that referenced this issue May 17, 2023
@netdiver
Update firewareos.rb (#2780)
f7de13f 
* Update firewareos.rb

Changed regex for prompt to accept the dash character and match with the <non-master> nodes of a fireware cluster.
Fixes #2779

* Update CHANGELOG.md
nickhilliard pushed a commit to nickhilliard/oxidized that referenced this issue Jun 15, 2023
@netdiver @nickhilliard
Update firewareos.rb (ytti#2780)
9b30a92 
* Update firewareos.rb

Changed regex for prompt to accept the dash character and match with the <non-master> nodes of a fireware cluster.
Fixes ytti#2779

* Update CHANGELOG.md
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update firewareos.rb
1 participant
@netdiver