Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix location of systemd service file on Debian systems #1840

Merged
merged 1 commit into from
Jul 2, 2020

Conversation

vincentbernat
Copy link
Contributor

Administrators are not expected to put files in /lib. The correct
location for the systemd service file is in
/etc/systemd/system (like for RHEL).

This is only a change in documentation. Also, I think we should not use SIGKILL as the kill. Is the issue still present in recent versions of oxidized? Just using SIGTERM works for me. Cc @mattie47

Administrators are not expected to put files in `/lib`. The correct
location for the systemd service file is in
`/etc/systemd/system` (like for RHEL).
@codecov-io
Copy link

codecov-io commented Jul 2, 2019

Codecov Report

Merging #1840 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1840   +/-   ##
=======================================
  Coverage   63.42%   63.42%           
=======================================
  Files          30       30           
  Lines        1490     1490           
=======================================
  Hits          945      945           
  Misses        545      545

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baf6876...7674120. Read the comment docs.

@mattie47
Copy link
Contributor

mattie47 commented Jul 2, 2019

@vincentbernat I'm not sure. I used oxidized for around a year on two different machines and the sigkill was always needed. Otherwise I always had to find the pid and kill -9 it.

I haven't used oxidized now in about a year so I don't know if anything has changed (in a different job).

@wk
Copy link
Contributor

wk commented Jul 2, 2020

Pulling this as-is, since the recommendation to use /etc/systemd/system is consistent with distribution guidelines. If SIGKILL vs SIGTERM is relevant and should be fixed, don't hesitate to open a separate PR!

Thank you!

@wk wk merged commit 77376da into ytti:master Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants