Model impovements for ios/comware/ironware/screenos and new model speedtouch

[raunz]

Pre-Request Checklist

• Passes rubocop code analysis (try rubocop --auto-correct)

Description

Comware model login prompt has changed in newer HPE devices. Fix for #1886
Wipe out 'flash free space' from some Brocade devices which use ironware model.
Added Thomson Speedtouch model.
Added gsub's to ios model, to ignore "configuration last changed", "NVRAM modified" lines from config and VTP status.

[codecov-io]

Codecov Report

Merging #1896 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1896   +/-   ##
=======================================
  Coverage   63.38%   63.38%           
=======================================
  Files          30       30           
  Lines        1491     1491           
=======================================
  Hits          945      945           
  Misses        546      546

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8543c73...5090565. Read the comment docs.

[ytti]

Please add speedtouch to supported platforms and in release notes. Looks great!

[raunz]

Please add speedtouch to supported platforms and in release notes. Looks great!

I've updated the documentation. I also included a small bugfix for ScreenOS model in the same branch.

[ytti]

Thanks!

[tyler-8]

I've got to say I object to the changes in 3599f90. That is removing critical details of when the config was actually modified on the device as well as the username that did the modification. That seems like a poor choice for default behavior - particularly since those lines have been included for all ios users up til this commit.

[raunz]

Due to buggy behaviour in IOS software it's wiser to remove 'last updated at/changed at'.
I prefer to get a diff only when a configuration actually changes. Also a major change in comment section is justified (e.g. change of serial number due to device hardware replacement).

Here's a example - I logged in, entered conf t but did not change anything, but the last configuration change time got udpated.

eli-sw1#sh ver
Cisco IOS Software, C2960X Software (C2960X-UNIVERSALK9-M), Version 15.2(4)E3, RELEASE SOFTWARE (fc2)
eli-sw1#sh run | i (change|updated)
! Last configuration change at 04:19:51 UTC Tue Oct 1 2019
! NVRAM config last updated at 12:31:07 UTC Thu Apr 25 2019 by sander
eli-sw1#conf t
Enter configuration commands, one per line.  End with CNTL/Z.
eli-sw1(config)#exit
eli-sw1#sh run | i (change|updated)
! Last configuration change at 05:35:23 UTC Tue Oct 1 2019 by rauno
! NVRAM config last updated at 12:31:07 UTC Thu Apr 25 2019 by sander

Also there's no need to trigger a commit, when a device has been rebooted and the timestamp of last change is null.
Also a pull #1904 preferred removal of these lines.