xmppdiff: Make more diffs interesting #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2060 +/- ##
=======================================
Coverage 63.32% 63.32%
=======================================
Files 30 30
Lines 1497 1497
=======================================
Hits 948 948
Misses 549 549 Continue to review full report at Codecov.
|
|
Can you please resolve the conficts and I'll merge |
jplitza
force-pushed
the
xmppdiff-interesting
branch
from
ff3cbc1 to
40ace3c
Compare
Previously, only diffs that contained added *and* deleted lines were considered "interesting". This is a curious definition that I was unable to find in other hooks, and definitely not what we wanted/expected.
jplitza
force-pushed
the
xmppdiff-interesting
branch
from
40ace3c to
44eaa62
Compare
|
Rebased (again) |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Request Checklist
rubocop --auto-correct)rake test)Description
Previously, only diffs that contained added and deleted lines were considered "interesting".
This is a curious definition that I was unable to find in other hooks, and definitely not what we wanted/expected.